Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add gitian build support for github pull request #13765

Merged
merged 1 commit into from Aug 22, 2018

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Jul 26, 2018

  • Add -p or --pull to specify the version is github pull request number

  • ./gitian-build.py -bpDn test 13765 should work. This is helpful for someone want to try cross compiling.

Copy link
Member

@kallewoof kallewoof left a comment

utACK bbf64d53374edb1be5dc7bd016369276addf3f56

@@ -135,6 +135,7 @@ def main():

parser = argparse.ArgumentParser(usage='%(prog)s [options] signer version')
parser.add_argument('-c', '--commit', action='store_true', dest='commit', help='Indicate that the version argument is for a commit or branch')
parser.add_argument('-p', '--pull', action='store_true', dest='pull', help='Indicate that the version argument is number of a github repository pull request')
Copy link
Member

@kallewoof kallewoof Jul 30, 2018

Nit/typo: is the number of a (the)

@ken2812221 ken2812221 force-pushed the gitian-build-pull branch from bbf64d5 to 46f8345 Jul 31, 2018
subprocess.check_call(['git', 'fetch', args.url, 'refs/pull/'+args.version+'/merge'])
args.commit = subprocess.check_output(['git', 'show', '-s', '--format=%H', 'FETCH_HEAD'], universal_newlines=True).strip()
args.version = 'pull-' + args.version
print(args.commit)
Copy link
Member

@laanwj laanwj Aug 7, 2018

is this intended or a left-over debug statement?

Copy link
Contributor Author

@ken2812221 ken2812221 Aug 9, 2018

That's intended, move from the above one.

@laanwj
Copy link
Member

@laanwj laanwj commented Aug 22, 2018

utACK 46f8345 in that case

@laanwj laanwj merged commit 46f8345 into bitcoin:master Aug 22, 2018
1 check passed
laanwj added a commit that referenced this issue Aug 22, 2018
46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c
@ken2812221 ken2812221 deleted the gitian-build-pull branch Aug 22, 2018
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 30, 2021
…l request

46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c

# Conflicts:
#	contrib/gitian-build.py
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 30, 2021
…l request

46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c

# Conflicts:
#	contrib/gitian-build.py
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 1, 2021
…l request

46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c

# Conflicts:
#	contrib/gitian-build.py
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 1, 2021
…l request

46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c

# Conflicts:
#	contrib/gitian-build.py
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 18, 2021
…l request

46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 18, 2021
…l request

46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 20, 2021
…l request

46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 20, 2021
…thub pull request"

This reverts commit 8fc7b74

Signed-off-by: pasta <pasta@dashboost.org>
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants