Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib: add gitian build support for github pull request #13765

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
4 participants
@ken2812221
Copy link
Member

commented Jul 26, 2018

  • Add -p or --pull to specify the version is github pull request number

  • ./gitian-build.py -bpDn test 13765 should work. This is helpful for someone want to try cross compiling.

@ken2812221 ken2812221 force-pushed the ken2812221:gitian-build-pull branch Jul 29, 2018

@kallewoof
Copy link
Member

left a comment

utACK bbf64d53374edb1be5dc7bd016369276addf3f56

contrib/gitian-build.py Outdated
@@ -135,6 +135,7 @@ def main():

parser = argparse.ArgumentParser(usage='%(prog)s [options] signer version')
parser.add_argument('-c', '--commit', action='store_true', dest='commit', help='Indicate that the version argument is for a commit or branch')
parser.add_argument('-p', '--pull', action='store_true', dest='pull', help='Indicate that the version argument is number of a github repository pull request')

This comment has been minimized.

Copy link
@kallewoof

kallewoof Jul 30, 2018

Member

Nit/typo: is the number of a (the)

@ken2812221 ken2812221 force-pushed the ken2812221:gitian-build-pull branch to 46f8345 Jul 31, 2018

subprocess.check_call(['git', 'fetch', args.url, 'refs/pull/'+args.version+'/merge'])
args.commit = subprocess.check_output(['git', 'show', '-s', '--format=%H', 'FETCH_HEAD'], universal_newlines=True).strip()
args.version = 'pull-' + args.version
print(args.commit)

This comment has been minimized.

Copy link
@laanwj

laanwj Aug 7, 2018

Member

is this intended or a left-over debug statement?

This comment has been minimized.

Copy link
@ken2812221

ken2812221 Aug 9, 2018

Author Member

That's intended, move from the above one.

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

utACK 46f8345 in that case

@laanwj laanwj merged commit 46f8345 into bitcoin:master Aug 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 22, 2018

Merge #13765: contrib: add gitian build support for github pull request
46f8345 contrib: Support github pull request gitian-build (Chun Kuan Lee)

Pull request description:

  - Add `-p` or `--pull` to specify the version is github pull request number

  - `./gitian-build.py -bpDn test 13765` should work. This is helpful for someone want to try cross compiling.

Tree-SHA512: b474b089127ffb2a67a42d99c1888bd5812a5ba725c8915a13a01cf93bde32b5b5011314e4193fa6b231caa5de2137e709ee5aa5bf889c4ac60a97aa83caac5c

@ken2812221 ken2812221 deleted the ken2812221:gitian-build-pull branch Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.