Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] Kill accounts #13825

Closed
wants to merge 18 commits into from

Conversation

Projects
None yet
10 participants
@jnewbery
Copy link
Member

commented Jul 31, 2018

To make space for new words, it's time to eliminate a word that has fallen into disuse: accounts. We make it fade into the night of time.

RIP accounts.

Completes #12952

@jnewbery jnewbery force-pushed the jnewbery:kill_accounts branch Jul 31, 2018

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Jul 31, 2018

@jnewbery jnewbery force-pushed the jnewbery:kill_accounts branch Jul 31, 2018

@jnewbery jnewbery referenced this pull request Jul 31, 2018

Closed

Remove wallet 'account' API #12952

6 of 6 tasks complete

@jnewbery jnewbery force-pushed the jnewbery:kill_accounts branch Jul 31, 2018

@fanquake fanquake added the Wallet label Jul 31, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #14021 (Import key origin data through importmulti by achow101)
  • #13462 (Simplify common case of CHashWriter and drop SerializeHash by Empact)
  • #11652 (Add missing locks: validation.cpp + related by practicalswift)
  • #11634 (wallet: Add missing cs_wallet/cs_KeyStore locks to wallet by practicalswift)
  • #10973 (Refactor: separate wallet from node by ryanofsky)
  • #10785 (Serialization improvements by sipa)
  • #10102 ([experimental] Multiprocess bitcoin by ryanofsky)
  • #9381 (Remove CWalletTx merging logic from AddToWallet by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 2, 2018

Bon débarras!

Concept ACK, looks good in a first skim of commits.

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2018

Rebased.

V0.17 is branched. This is now ready for review/merge.

@jnewbery jnewbery changed the title [wallet] [Do not merge until v0.18] Kill accounts [wallet] Kill accounts Aug 14, 2018

@DrahtBot DrahtBot removed the Needs rebase label Aug 14, 2018

@meshcollider

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

I think the general agreement towards this is clear but Concept ACK regardless. Will try and find time to review this soon

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2018

Perec redacted to remove any potential copyright material from git logs 😢

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2018

rebased

@jnewbery jnewbery force-pushed the jnewbery:kill_accounts branch to 3053884 Aug 27, 2018

@jnewbery jnewbery changed the title [WIP] [wallet] Kill accounts [wallet] Kill accounts Aug 27, 2018

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2018

The 'account' RPC has been removed in #14023. This PR removes all dead code left behind by that PR.

@DrahtBot DrahtBot removed the Needs rebase label Aug 27, 2018

@promag

This comment has been minimized.

Copy link
Member

commented Aug 28, 2018

Care to fix #14023 (comment)?

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 29, 2018

utACK 3053884
agree fixing @promag's nit would be nice

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2018

Thanks @laanwj & @promag . Typo fixed in 85ec8d6

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

re-utACK 85ec8d6

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

utACK 85ec8d6

@gmaxwell

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

utACK .. but mostly I just like the PR text.

@ajtowns

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2018

utACK 85ec8d6

Some of the changes for the "GetLabelDestination" commit (53038b4) are actually in the following "Delete unused account functions" commit, causing "make all" to fail. Otherwise looks good.

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2018

4 utACKs. Rather than fix the build break in the intermediate commit, I think it makes sense to just squash everything down to one commit (I only split it up so granularly to aid reviews).

@laanwj - if you agree, I'm happy for you to squash these down when you merge, or I can do it. Let me know.

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

@jnewbery ok, I'll do that, no problem

pull bot pushed a commit to jaschadub/bitcoin that referenced this pull request Aug 30, 2018

Merge bitcoin#13825: [wallet] Kill accounts
c9c32e6 [wallet] Kill accounts (John Newbery)

Tree-SHA512: 783272e7df9042fb0a01826fa37a02b97218496459015d7457e56223da8690bdad930c223dd4a903a1d4df57f3f2f4a097d392d272a72419ea9a882b11e599f7

@MarcoFalke MarcoFalke closed this Aug 30, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

This was squashed to c9c32e6 and merged

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 30, 2018

yep
I should probably have left the [doc] commit separate, nah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.