Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add testing of value_ret for SelectCoinsBnB #13861

Merged
merged 1 commit into from Aug 27, 2018

Conversation

@Empact
Copy link
Member

@Empact Empact commented Aug 3, 2018

Fix that the early bailout optimization tests did not test the intended
selection because their utxo pool was polluted by the make_hard_case test
preceding. Note the code was tested, just not with the constructed case.

@Empact
Copy link
Member Author

@Empact Empact commented Aug 3, 2018

Extracted from #13222

@Empact Empact force-pushed the test-value-ret-select-coins-bnb branch from 48c18be to a6b0706 Aug 3, 2018
Fix that the early bailout optimization tests did not test the actual
selection because their utxo pool was polluted by the make_hard_case test
preceding.
@Empact Empact force-pushed the test-value-ret-select-coins-bnb branch from a6b0706 to 3842732 Aug 3, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Aug 3, 2018

No more conflicts as of last run.

@fanquake fanquake added the Tests label Aug 3, 2018
@laanwj
Copy link
Member

@laanwj laanwj commented Aug 22, 2018

utACK 3842732, thanks for adding tests

@laanwj laanwj merged commit 3842732 into bitcoin:master Aug 27, 2018
1 check passed
laanwj added a commit that referenced this issue Aug 27, 2018
3842732 test: Add testing of value_ret for SelectCoinsBnB (Ben Woosley)

Pull request description:

  Fix that the early bailout optimization tests did not test the intended
  selection because their utxo pool was polluted by the make_hard_case test
  preceding. Note the code was tested, just not with the constructed case.

Tree-SHA512: 95f665525f5922f70f4c17708c0c09900f38d7a652b5bdd817e017ba7ff2865a6234edbd340064ffccc20d34048c45df86a4ac5f46dd8f4aab98834e71dc9d3c
@Empact Empact deleted the test-value-ret-select-coins-bnb branch Oct 9, 2018
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Jan 16, 2020
Summary:
384273260a6ccbcf79dade0830011f528e5a1581 test: Add testing of value_ret for SelectCoinsBnB (Ben Woosley)

Pull request description:

  Fix that the early bailout optimization tests did not test the intended
  selection because their utxo pool was polluted by the make_hard_case test
  preceding. Note the code was tested, just not with the constructed case.

Tree-SHA512: 95f665525f5922f70f4c17708c0c09900f38d7a652b5bdd817e017ba7ff2865a6234edbd340064ffccc20d34048c45df86a4ac5f46dd8f4aab98834e71dc9d3c

Backport of Core PR13861
bitcoin/bitcoin#13861

Test Plan:
  ninja check

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4963
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 15, 2021
3842732 test: Add testing of value_ret for SelectCoinsBnB (Ben Woosley)

Pull request description:

  Fix that the early bailout optimization tests did not test the intended
  selection because their utxo pool was polluted by the make_hard_case test
  preceding. Note the code was tested, just not with the constructed case.

Tree-SHA512: 95f665525f5922f70f4c17708c0c09900f38d7a652b5bdd817e017ba7ff2865a6234edbd340064ffccc20d34048c45df86a4ac5f46dd8f4aab98834e71dc9d3c
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants