Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add testing of value_ret for SelectCoinsBnB #13861

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
4 participants
@Empact
Copy link
Member

commented Aug 3, 2018

Fix that the early bailout optimization tests did not test the intended
selection because their utxo pool was polluted by the make_hard_case test
preceding. Note the code was tested, just not with the constructed case.

@Empact

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2018

Extracted from #13222

@Empact Empact force-pushed the Empact:test-value-ret-select-coins-bnb branch Aug 3, 2018

test: Add testing of value_ret for SelectCoinsBnB
Fix that the early bailout optimization tests did not test the actual
selection because their utxo pool was polluted by the make_hard_case test
preceding.

@Empact Empact force-pushed the Empact:test-value-ret-select-coins-bnb branch to 3842732 Aug 3, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2018

No more conflicts as of last run.

@fanquake fanquake added the Tests label Aug 3, 2018

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

utACK 3842732, thanks for adding tests

@laanwj laanwj merged commit 3842732 into bitcoin:master Aug 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 27, 2018

Merge #13861: test: Add testing of value_ret for SelectCoinsBnB
3842732 test: Add testing of value_ret for SelectCoinsBnB (Ben Woosley)

Pull request description:

  Fix that the early bailout optimization tests did not test the intended
  selection because their utxo pool was polluted by the make_hard_case test
  preceding. Note the code was tested, just not with the constructed case.

Tree-SHA512: 95f665525f5922f70f4c17708c0c09900f38d7a652b5bdd817e017ba7ff2865a6234edbd340064ffccc20d34048c45df86a4ac5f46dd8f4aab98834e71dc9d3c

@Empact Empact deleted the Empact:test-value-ret-select-coins-bnb branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.