Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: Enable bdb unicode support for Windows #13884

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
6 participants
@ken2812221
Copy link
Member

commented Aug 5, 2018

define UNICODE and _UNICODE while compiling for Windows. This would make dbd read filename as utf8 string.

@ken2812221 ken2812221 referenced this pull request Aug 5, 2018

Closed

Filename and command line encoding issue on Windows #13869

11 of 12 tasks complete

@ken2812221 ken2812221 changed the title depends: Enable unicode support on dbd for Windows depends: Enable bdb unicode support for Windows Aug 5, 2018

@laanwj laanwj added the Windows label Aug 6, 2018

@meshcollider

This comment has been minimized.

Copy link
Member

commented Nov 19, 2018

utACK 5bb0164

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Nov 19, 2018

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jan 3, 2019

Merge bitcoin#13884: depends: Enable bdb unicode support for Windows
5bb0164 depends: Enable unicode support on dbd for Windows (Chun Kuan Lee)

Pull request description:

  define `UNICODE` and `_UNICODE` while compiling for Windows. This would make dbd read filename as utf8 string.

Tree-SHA512: 58ee86ca5333c416c7c4db8266887c085c486cabfbb68c6bd0e66519abb3abfedac6bb7d28e4228eb5c2c4436e4e5060eb7b22490044143b6676d23fc627540a

@MarcoFalke MarcoFalke merged commit 5bb0164 into bitcoin:master Jan 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ken2812221 ken2812221 deleted the ken2812221:bdb-utf8 branch Jan 3, 2019

@fanquake

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

Should this be backported?

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Jan 3, 2019

It could, but without unicode support from leveldb, the gains are rather limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.