Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends: Enable bdb unicode support for Windows #13884

Merged
merged 1 commit into from Jan 3, 2019

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Aug 5, 2018

define UNICODE and _UNICODE while compiling for Windows. This would make dbd read filename as utf8 string.

@ken2812221 ken2812221 changed the title depends: Enable unicode support on dbd for Windows depends: Enable bdb unicode support for Windows Aug 5, 2018
@laanwj laanwj added the Windows label Aug 6, 2018
@meshcollider
Copy link
Member

@meshcollider meshcollider commented Nov 19, 2018

utACK 5bb0164

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Nov 19, 2018
MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Jan 3, 2019
5bb0164 depends: Enable unicode support on dbd for Windows (Chun Kuan Lee)

Pull request description:

  define `UNICODE` and `_UNICODE` while compiling for Windows. This would make dbd read filename as utf8 string.

Tree-SHA512: 58ee86ca5333c416c7c4db8266887c085c486cabfbb68c6bd0e66519abb3abfedac6bb7d28e4228eb5c2c4436e4e5060eb7b22490044143b6676d23fc627540a
@MarcoFalke MarcoFalke merged commit 5bb0164 into bitcoin:master Jan 3, 2019
2 checks passed
@ken2812221 ken2812221 deleted the bdb-utf8 branch Jan 3, 2019
@fanquake
Copy link
Member

@fanquake fanquake commented Jan 3, 2019

Should this be backported?

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Jan 3, 2019

It could, but without unicode support from leveldb, the gains are rather limited.

deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Mar 31, 2020
Summary:
```
define UNICODE and _UNICODE while compiling for Windows. This would make
dbd read filename as utf8 string.
```

Backport of core [[bitcoin/bitcoin#13884 | PR13884]].

Test Plan: Run the Windows Gitian builds.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5604
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue Aug 17, 2020
Summary:
```
define UNICODE and _UNICODE while compiling for Windows. This would make
dbd read filename as utf8 string.
```

Backport of core [[bitcoin/bitcoin#13884 | PR13884]].

Test Plan: Run the Windows Gitian builds.

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5604
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 26, 2021
5bb0164 depends: Enable unicode support on dbd for Windows (Chun Kuan Lee)

Pull request description:

  define `UNICODE` and `_UNICODE` while compiling for Windows. This would make dbd read filename as utf8 string.

Tree-SHA512: 58ee86ca5333c416c7c4db8266887c085c486cabfbb68c6bd0e66519abb3abfedac6bb7d28e4228eb5c2c4436e4e5060eb7b22490044143b6676d23fc627540a
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
5bb0164 depends: Enable unicode support on dbd for Windows (Chun Kuan Lee)

Pull request description:

  define `UNICODE` and `_UNICODE` while compiling for Windows. This would make dbd read filename as utf8 string.

Tree-SHA512: 58ee86ca5333c416c7c4db8266887c085c486cabfbb68c6bd0e66519abb3abfedac6bb7d28e4228eb5c2c4436e4e5060eb7b22490044143b6676d23fc627540a
random-zebra added a commit to PIVX-Project/PIVX that referenced this issue Aug 5, 2021
63e0be6 [Remove] By-pass logprint-scanner restriction. (furszy)
280ced3 utils: Fix broken Windows filelock (Chun Kuan Lee)
be89860 utils: Convert Windows args to utf-8 string (Chun Kuan Lee)
e8cfa6e Call unicode API on Windows (Chun Kuan Lee)
1a02a8a tests: Add test case for std::ios_base::ate (Chun Kuan Lee)
2e57cd4 Move boost/std fstream to fsbridge (furszy)
9d8bcd4 utils: Add fsbridge fstream function wrapper (Chun Kuan Lee)
d59d48d utils: Convert fs error messages from multibyte to utf-8 (ken2812221)
9ef58cc Logging: use "fmterr" variable name for errors instead of general "e" that can be used by any other function. (furszy)
dd94241 utils: Use _wfopen and _wreopen on Windows (Chun Kuan Lee)
3993641 add unicode compatible file_lock for Windows (Chun Kuan Lee)
48349f8 Provide relevant error message if datadir is not writable. (murrayn)

Pull request description:

  As the software is currently using the ANSI encoding on Windows, the user's language settings could affect the proper functioning of the node/wallet, to the point of not be able to open some non-ASCII name files and directories.

  This solves the Windows encoding issues, completing the entire bitcoin#13869 work path (and some other required backports). Enabling for example users that use non-english characters in directories and file names to be accepted.

  Backported PRs:
  * bitcoin#12422.
  * bitcoin#12630.
  * bitcoin#13862.
  * bitcoin#13866.
  * bitcoin#13877.
  * bitcoin#13878.
  * bitcoin#13883.
  * bitcoin#13884.
  * bitcoin#13886.
  * bitcoin#13888.
  * bitcoin#14192.
  * bitcoin#13734.
  * bitcoin#14426.

  This is built on top of other two PRs that i have open #2423 and #2369.
  Solves old issues #940 and #2163.

  TODO:
  * Backport `assert_start_raises_init_error` and `ErrorMatch` in TestNode` (bitcoin#12718)

ACKs for top commit:
  Fuzzbawls:
    ACK 63e0be6
  random-zebra:
    ACK 63e0be6 and merging...

Tree-SHA512: cb1f7c23abb5b7b3af50bba18652cc2cad93fd7c2fca9c16ffd3fee34c4c152a3b666dfa87fe6b44c430064dcdee4367144dcb4a41203c91b0173b805bdb3d7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants