Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call unicode API on Windows #13888

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
6 participants
@ken2812221
Copy link
Member

commented Aug 6, 2018

Call Unicode API on Windows

@ken2812221 ken2812221 referenced this pull request Aug 6, 2018

Closed

Filename and command line encoding issue on Windows #13869

11 of 12 tasks complete

@laanwj laanwj added the Windows label Aug 6, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:windows-force-w branch Aug 11, 2018

@donaloconnor
Copy link
Contributor

left a comment

utACK 465f353

@alexeyneu

This comment has been minimized.

Copy link

commented Aug 12, 2018

i doubt that linker will change entry point coz of this . main to wmain change

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2018

@alexeyneu How could that happen?

@alexeyneu

This comment has been minimized.

Copy link

commented Aug 12, 2018

unicode support means :

int wmain(int argc, wchar_t* argv[])

and /ENTRY:wmainCRTStartup in FLAGS . I strongly doubt that latter is added by gcc-msys-winlinux hybrid.
native unicode .exe makefile:
https://github.com/alexeyneu/json-demo/blob/master/makefile

@sipa

This comment has been minimized.

Copy link
Member

commented Aug 12, 2018

@alexeyneu That seems to only affect whether or not command line arguments are passed in as wchar.

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2018

@alexeyneu You can see #13883 how I solve this. Since we are using mingw. The linker will link wmain only if you pass -municode to it, but I don't do this.

@alexeyneu

This comment has been minimized.

Copy link

commented Aug 12, 2018

@ken2812221 yeah it does the trick in msys . I've thinkin that you pretend to solve whole issue mentioned
@sipa looks like it's command line related even in msvc

@ken2812221 ken2812221 force-pushed the ken2812221:windows-force-w branch Aug 26, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:windows-force-w branch to d38bf91 Sep 11, 2018

@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

utACK d38bf91

@laanwj laanwj merged commit d38bf91 into bitcoin:master Sep 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 13, 2018

Merge #13888: Call unicode API on Windows
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309

@ken2812221 ken2812221 deleted the ken2812221:windows-force-w branch Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.