Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call unicode API on Windows #13888

Merged
merged 1 commit into from Sep 13, 2018
Merged

Call unicode API on Windows #13888

merged 1 commit into from Sep 13, 2018

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Aug 6, 2018

Call Unicode API on Windows

Copy link
Contributor

@donaloconnor donaloconnor left a comment

utACK 465f353

@alexeyneu
Copy link

@alexeyneu alexeyneu commented Aug 12, 2018

i doubt that linker will change entry point coz of this . main to wmain change

@ken2812221
Copy link
Contributor Author

@ken2812221 ken2812221 commented Aug 12, 2018

@alexeyneu How could that happen?

@alexeyneu
Copy link

@alexeyneu alexeyneu commented Aug 12, 2018

unicode support means :

int wmain(int argc, wchar_t* argv[])

and /ENTRY:wmainCRTStartup in FLAGS . I strongly doubt that latter is added by gcc-msys-winlinux hybrid.
native unicode .exe makefile:
https://github.com/alexeyneu/json-demo/blob/master/makefile

@sipa
Copy link
Member

@sipa sipa commented Aug 12, 2018

@alexeyneu That seems to only affect whether or not command line arguments are passed in as wchar.

@ken2812221
Copy link
Contributor Author

@ken2812221 ken2812221 commented Aug 12, 2018

@alexeyneu You can see #13883 how I solve this. Since we are using mingw. The linker will link wmain only if you pass -municode to it, but I don't do this.

@alexeyneu
Copy link

@alexeyneu alexeyneu commented Aug 12, 2018

@ken2812221 yeah it does the trick in msys . I've thinkin that you pretend to solve whole issue mentioned
@sipa looks like it's command line related even in msvc

@laanwj
Copy link
Member

@laanwj laanwj commented Sep 13, 2018

utACK d38bf91

@laanwj laanwj merged commit d38bf91 into bitcoin:master Sep 13, 2018
2 checks passed
laanwj added a commit that referenced this issue Sep 13, 2018
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
@ken2812221 ken2812221 deleted the windows-force-w branch Sep 13, 2018
Warrows added a commit to Warrows/PIVX that referenced this issue Oct 14, 2019
Warrows added a commit to Warrows/PIVX that referenced this issue Nov 23, 2019
@bitcoin bitcoin deleted a comment from adriannavarrobetrian May 10, 2020
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
d38bf91 Call unicode API on Windows (Chun Kuan Lee)

Pull request description:

  Call Unicode API on Windows

Tree-SHA512: 93c290ee79c9d911fdada8ba45e184fc4f14d3cb56f33f39223286213878b08e8c4dd296a80099c57797d3b8589870e6cff622b22e76123d7452659d49dd8309
random-zebra added a commit to PIVX-Project/PIVX that referenced this issue Aug 5, 2021
63e0be6 [Remove] By-pass logprint-scanner restriction. (furszy)
280ced3 utils: Fix broken Windows filelock (Chun Kuan Lee)
be89860 utils: Convert Windows args to utf-8 string (Chun Kuan Lee)
e8cfa6e Call unicode API on Windows (Chun Kuan Lee)
1a02a8a tests: Add test case for std::ios_base::ate (Chun Kuan Lee)
2e57cd4 Move boost/std fstream to fsbridge (furszy)
9d8bcd4 utils: Add fsbridge fstream function wrapper (Chun Kuan Lee)
d59d48d utils: Convert fs error messages from multibyte to utf-8 (ken2812221)
9ef58cc Logging: use "fmterr" variable name for errors instead of general "e" that can be used by any other function. (furszy)
dd94241 utils: Use _wfopen and _wreopen on Windows (Chun Kuan Lee)
3993641 add unicode compatible file_lock for Windows (Chun Kuan Lee)
48349f8 Provide relevant error message if datadir is not writable. (murrayn)

Pull request description:

  As the software is currently using the ANSI encoding on Windows, the user's language settings could affect the proper functioning of the node/wallet, to the point of not be able to open some non-ASCII name files and directories.

  This solves the Windows encoding issues, completing the entire bitcoin#13869 work path (and some other required backports). Enabling for example users that use non-english characters in directories and file names to be accepted.

  Backported PRs:
  * bitcoin#12422.
  * bitcoin#12630.
  * bitcoin#13862.
  * bitcoin#13866.
  * bitcoin#13877.
  * bitcoin#13878.
  * bitcoin#13883.
  * bitcoin#13884.
  * bitcoin#13886.
  * bitcoin#13888.
  * bitcoin#14192.
  * bitcoin#13734.
  * bitcoin#14426.

  This is built on top of other two PRs that i have open #2423 and #2369.
  Solves old issues #940 and #2163.

  TODO:
  * Backport `assert_start_raises_init_error` and `ErrorMatch` in TestNode` (bitcoin#12718)

ACKs for top commit:
  Fuzzbawls:
    ACK 63e0be6
  random-zebra:
    ACK 63e0be6 and merging...

Tree-SHA512: cb1f7c23abb5b7b3af50bba18652cc2cad93fd7c2fca9c16ffd3fee34c4c152a3b666dfa87fe6b44c430064dcdee4367144dcb4a41203c91b0173b805bdb3d7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants