Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] Remove getinfo deprecation warning #13891

Merged
merged 1 commit into from Aug 15, 2018

Conversation

Projects
None yet
7 participants
@jnewbery
Copy link
Member

commented Aug 6, 2018

getinfo was removed in V0.16. A removal warning message was left in place to tell users that the method had been removed. We can remove that entirely in V0.18.

@jnewbery jnewbery changed the title [DO NOT REMOVE UNTIL V0.18] [RPC] Remove getinfo deprecation warning [DO NOT MERGE UNTIL V0.18] [RPC] Remove getinfo deprecation warning Aug 6, 2018

@fanquake fanquake added this to the 0.18.0 milestone Aug 6, 2018

@achow101

This comment has been minimized.

Copy link
Member

commented Aug 6, 2018

utACK b2f23c4

1 similar comment
@domob1812

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2018

utACK b2f23c4

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 8, 2018

~0 on this, wouldn't mind letting this wait another major version, but also ok with removing it if everyone thinks that this is common knowledge now

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #13945 (Refactoring CRPCCommand with enum category by isghe)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2018

wouldn't mind letting this wait another major version

This won't be in a release until V0.18, which should be Feb/March 2019. getinfo was first marked as deprecated in V0.14 (#8780) and removed in V0.16 (#10838), with a deprecation warning added in that release (#12198).

Two releases saying a feature is going to be deprecated (v0.14 & v0.15), then two releases saying the feature has been deprecated (v0.16 and v0.17) seems like plenty of warning to me.

@jnewbery jnewbery changed the title [DO NOT MERGE UNTIL V0.18] [RPC] Remove getinfo deprecation warning [RPC] Remove getinfo deprecation warning Aug 14, 2018

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2018

V0.17 has been branched. This is ready for review/merge.

@ken2812221

This comment has been minimized.

Copy link
Member

commented Aug 14, 2018

utACK b2f23c4

ken2812221 pushed a commit to ken2812221/bitcoin that referenced this pull request Aug 15, 2018

Merge bitcoin#13891: [RPC] Remove getinfo deprecation warning
b2f23c4 [RPC] Remove getinfo deprecation warning (John Newbery)

Pull request description:

  `getinfo` was removed in V0.16. A removal warning message was left in place to tell users that the method had been removed. We can remove that entirely in V0.18.

Tree-SHA512: bf93fbcf57a9be480438dcbdcab2dfd69ce277218b10628776975b093b3ffd2caa1751e0fb4cb0245443c81465693e2b8750e96d3e38632a78bae5ffa04f9212

@laanwj laanwj merged commit b2f23c4 into bitcoin:master Aug 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.