New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log progress while verifying blocks at level 4 #13910

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
4 participants
@domob1812
Copy link
Contributor

domob1812 commented Aug 8, 2018

When verifying blocks at startup, the progress is printed in 10% increments to logs. When -checklevel=4, however, the second half of the verification (connecting the blocks again) does not log the progress anymore. (It is still computed and shown in the UI, but not printed to logs.)

This change makes the behaviour consistent, by adding the missing progress logging also for level-4 checks.

Log progress while verifying blocks at level 4.
When verifying blocks at startup, the progress is printed in 10%
increments to logs.  When -checklevel=4, however, the second half
of the verification (connecting the blocks again) does not log the
progress anymore.  (It is still computed and shown in the UI, but
not printed to logs.)

This change makes the behaviour consistent, by adding the missing
progress logging also for level-4 checks.
@luke-jr
Copy link
Member

luke-jr left a comment

utACK

@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Oct 20, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Oct 20, 2018

utACK e58985c

@domob1812

This comment has been minimized.

Copy link
Contributor

domob1812 commented Jan 4, 2019

Friendly ping - anything I should do to get this merged?

@MarcoFalke MarcoFalke changed the title Trivial: Log progress while verifying blocks at level 4 Log progress while verifying blocks at level 4 Jan 4, 2019

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Jan 4, 2019

Merge bitcoin#13910: Log progress while verifying blocks at level 4
e58985c Log progress while verifying blocks at level 4. (Daniel Kraft)

Pull request description:

  When verifying blocks at startup, the progress is printed in 10% increments to logs.  When `-checklevel=4`, however, the second half of the verification (connecting the blocks again) does not log the progress anymore.  (It is still computed and shown in the UI, but not printed to logs.)

  This change makes the behaviour consistent, by adding the missing progress logging also for level-4 checks.

Tree-SHA512: 6a4c5914726fc1a1337de0c5130b20d4edf4e2feeb0aa0449d2ce422b2d8c41e56ede94163a02044d9a28ac4dc6624b1ad611da93ce5792ff32ad9fb1f0ea1e0

@MarcoFalke MarcoFalke merged commit e58985c into bitcoin:master Jan 4, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@domob1812 domob1812 deleted the domob1812:progress branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment