Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation in bitcoin-util-test.py #13953

Merged

Conversation

Projects
None yet
4 participants
@isghe
Copy link
Contributor

commented Aug 13, 2018

To avoid:

$ make check
{…omissis…}
Running test/util/bitcoin-util-test.py...
/usr/local/bin/python3.7 ../test/util/bitcoin-util-test.py
../test/util/bitcoin-util-test.py:31: DeprecationWarning: This method will be removed in future versions. Use 'parser.read_file()' instead.
config.readfp(open(os.path.join(os.path.dirname(file), "../config.ini"), encoding="utf8"))

$ python3 --version
Python 3.7.0

fix deprecation in bitcoin-util-test.py
To avoid:

$ make check
{…omissis…}
Running test/util/bitcoin-util-test.py...
/usr/local/bin/python3.7 ../test/util/bitcoin-util-test.py
../test/util/bitcoin-util-test.py:31: DeprecationWarning: This method will be removed in future versions.  Use 'parser.read_file()' instead.
config.readfp(open(os.path.join(os.path.dirname(__file__), "../config.ini"), encoding="utf8"))

$ python3 --version
Python 3.7.0

@fanquake fanquake added the Tests label Aug 13, 2018

@MarcoFalke MarcoFalke added this to the 0.18.0 milestone Aug 13, 2018

@fanquake

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

read_file() has been available since 3.2, so this doesn't increase the minimum Python requirement.

@domob1812

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2018

utACK 49e5662

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Aug 13, 2018

Merge bitcoin#13953: fix deprecation in bitcoin-util-test.py
49e5662 fix deprecation in bitcoin-util-test.py (Isidoro Ghezzi)

Pull request description:

  To avoid:

  $ make check
  {…omissis…}
  Running test/util/bitcoin-util-test.py...
  /usr/local/bin/python3.7 ../test/util/bitcoin-util-test.py
  ../test/util/bitcoin-util-test.py:31: DeprecationWarning: This method will be removed in future versions.  Use 'parser.read_file()' instead.
  config.readfp(open(os.path.join(os.path.dirname(__file__), "../config.ini"), encoding="utf8"))

  $ python3 --version
  Python 3.7.0

Tree-SHA512: eafed629b64ae32b0b84520bb9b430204cba38d426dab1b3946a92c758c7d599aacc2798ab6e126808a6c7515ff20eb4ecc635b3e424f4c8903105438f817297

@MarcoFalke MarcoFalke merged commit 49e5662 into bitcoin:master Aug 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@isghe isghe deleted the isghe:fix-deprecation-in-bitcoin-util-test branch Aug 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.