Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[walletdb] don't report minversion wallet entry as unknown #13967

Merged
merged 1 commit into from Aug 22, 2018

Conversation

@instagibbs
Copy link
Member

@instagibbs instagibbs commented Aug 14, 2018

It is known in WalletBatch::LoadWallet

@laanwj laanwj added the Wallet label Aug 14, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Aug 14, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #13825 ([wallet] Kill accounts by jnewbery)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj
Copy link
Member

@laanwj laanwj commented Aug 22, 2018

utACK 321159e

@laanwj laanwj merged commit 321159e into bitcoin:master Aug 22, 2018
1 check passed
laanwj added a commit that referenced this issue Aug 22, 2018
321159e don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

  It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d
@jnewbery
Copy link
Member

@jnewbery jnewbery commented Aug 23, 2018

post-merge utACK 321159e

@r8921039
Copy link
Contributor

@r8921039 r8921039 commented Dec 27, 2018

I just encountered this "unknown wallet records" issue today when running the latest 0.17.1 (upgraded from 0.17.0). Not sure bitcoincore's backport policy but it seems to me it would be nice to have this simple fix on 0.17.2.

Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 30, 2021
…as unknown

321159e don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

  It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d

# Conflicts:
#	src/wallet/walletdb.cpp
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 30, 2021
…as unknown

321159e don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

  It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d

# Conflicts:
#	src/wallet/walletdb.cpp
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 1, 2021
…as unknown

321159e don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

  It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d

# Conflicts:
#	src/wallet/walletdb.cpp
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 2, 2021
…as unknown

321159e don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

  It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d

# Conflicts:
#	src/wallet/walletdb.cpp
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 2, 2021
…as unknown

321159e don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

  It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d

# Conflicts:
#	src/wallet/walletdb.cpp
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 2, 2021
…as unknown

321159e don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

  It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d

# Conflicts:
#	src/wallet/walletdb.cpp
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants