Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[walletdb] don't report minversion wallet entry as unknown #13967

Merged
merged 1 commit into from Aug 22, 2018

Conversation

Projects
None yet
6 participants
@instagibbs
Copy link
Member

commented Aug 14, 2018

It is known in WalletBatch::LoadWallet

@laanwj laanwj added the Wallet label Aug 14, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #13825 ([wallet] Kill accounts by jnewbery)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot referenced this pull request Aug 14, 2018

Closed

[wallet] Kill accounts #13825

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

utACK 321159e

@laanwj laanwj merged commit 321159e into bitcoin:master Aug 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 22, 2018

Merge #13967: [walletdb] don't report minversion wallet entry as unknown
321159e don't report minversion wallet entry as unknown (Gregory Sanders)

Pull request description:

  It is known in WalletBatch::LoadWallet

Tree-SHA512: 82f7e12f48ae7d17317074ce5b5e27c70ba8334b04adbf7cc863f8169cc1aa460b9454571e2698aa00059c8c8f669fe19c0d40c4910dcded260ddca6ce78be9d
@jnewbery

This comment has been minimized.

Copy link
Member

commented Aug 23, 2018

post-merge utACK 321159e

@r8921039

This comment has been minimized.

Copy link
Contributor

commented Dec 27, 2018

I just encountered this "unknown wallet records" issue today when running the latest 0.17.1 (upgraded from 0.17.0). Not sure bitcoincore's backport policy but it seems to me it would be nice to have this simple fix on 0.17.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.