Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
rpc: Return more specific reject reason for submitblock #13983
The second commit in #13439 made the
The meaning of
Yeah, submitblock had zero test coverage previously, which is why this was missed during review I guess.
Personally I don't care about the specificness of the return code for invalid blocks (since in normal operation you'd never submit invalid blocks), but we might want to backport this if some miner cares.
ryanofsky left a comment
utACK fa6ab8a. I'm not very familiar with this logic, but the code change is simple and matches the description, and the new test coverage is good.
Two possible suggestions:
Sep 13, 2018
@ryanofsky I believe the changes here only affect the return value of invalid blocks. I'd be surprised to see someone submitting invalid blocks in production. Also, I believe this restores the behavior that existed before 0.17.0.
If someone feels strongly they could backport that to 0.17.0, but at this point it might be too late to get in.