Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor: fetch the latest port data #13997

Merged
merged 1 commit into from Aug 17, 2018

Conversation

Projects
None yet
2 participants
@ken2812221
Copy link
Member

commented Aug 17, 2018

Discussion in #13964 (comment) , fetch the latest port data before installing it.

@MarcoFalke
Copy link
Member

left a comment

Concept ACK, if this fixes the broken build.

Nit: Since you touch this file, might as well add a line version: '{branch}.{build}', so its easier to see which branch is built?

appveyor.yml Outdated
@@ -24,6 +24,8 @@ before_build:
$all_packages += $packages[$i] + ":" + $env:PLATFORM + "-windows-static "
}

git -C C:\Tools\vcpkg pull

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Aug 17, 2018

Member

Is it possible to add a trailing comment to this line, explaining that this is only temporary?

@MarcoFalke MarcoFalke added the Tests label Aug 17, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:patch-2 branch to ea16c2d Aug 17, 2018

@MarcoFalke MarcoFalke closed this Aug 17, 2018

@MarcoFalke MarcoFalke reopened this Aug 17, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Aug 17, 2018

utACK ea16c2d

@MarcoFalke MarcoFalke merged commit ea16c2d into bitcoin:master Aug 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Aug 17, 2018

Merge #13997: appveyor: fetch the latest port data
ea16c2d appveyor: fetch the latest port data (Chun Kuan Lee)

Pull request description:

  Discussion in #13964 (comment) , fetch the latest port data before installing it.

Tree-SHA512: a3b95aeb3b298130ff0617a8dec5c97c0882cf7a3b72ce792e63d8f2c2ac4a297dfa0d3357878c2198a9fea62d0f24df56598293dde88963dd043e121be4dc3a

@ken2812221 ken2812221 deleted the ken2812221:patch-2 branch Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.