Preserve a format of RPC command definitions #14008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyantyn
commented
Aug 20, 2018
| * @param[in] tx transaction for which we are checking input total | ||
| * @return Sum of value of all inputs (scriptSigs) | ||
| * @param[in] tx transaction for which we are checking input total | ||
| * @return Sum of value of all inputs (scriptSigs) |
There was a problem hiding this comment.
for reviewers: I replaced tabs with spaces because if this block is moved, the test/lint/lint-whitespace.sh will fail.
Currently RPC commands are formatted in a way that it's easy to read and that test/lint/check-rpc-mappings.py can parse it. To void breaking test/lint/check-rpc-mappings.py script by running clang-format, RPC command definitions should be disabled for clang-format.
kostyantyn
force-pushed
the
preserve_format_of_rpc_command_definitions
branch
from
f378b89
to
d9d7957
Compare
Note to reviewers: This pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
scravy
approved these changes
Aug 21, 2018
|
ACK, looks good to me |
|
yes, this makes sense, otherwise clang-format will mess up the tables |
laanwj
added a commit
that referenced
this pull request
Sep 10, 2018
d9d7957 Preserve a format of RPC command definitions (Kostiantyn Stepaniuk) Pull request description: Currently, RPC commands are formatted in a way that it's easy to read and that `test/lint/check-rpc-mappings.py` can parse it. To void breaking `test/lint/check-rpc-mappings.py` script by running `clang-format`, RPC command definitions should be disabled for clang-format. Tree-SHA512: e17d20ec0e6c4e19410198b55687ebbe6fa01654d214d4578cd16c00b872bf8b0b306594a45523685cd2e9d9280702e00471d9366e87954428e8bbeacd8cad60
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, RPC commands are formatted in a way that it's easy to read
and that
test/lint/check-rpc-mappings.pycan parse it.To void breaking
test/lint/check-rpc-mappings.pyscript by runningclang-format, RPC command definitions should be disabled for clang-format.