Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve a format of RPC command definitions #14008

Merged

Conversation

@kostyantyn
Copy link
Contributor

@kostyantyn kostyantyn commented Aug 20, 2018

Currently, RPC commands are formatted in a way that it's easy to read
and that test/lint/check-rpc-mappings.py can parse it.

To void breaking test/lint/check-rpc-mappings.py script by running
clang-format, RPC command definitions should be disabled for clang-format.

* @param[in] tx transaction for which we are checking input total
* @return Sum of value of all inputs (scriptSigs)
* @param[in] tx transaction for which we are checking input total
* @return Sum of value of all inputs (scriptSigs)
Copy link
Contributor Author

@kostyantyn kostyantyn Aug 20, 2018

for reviewers: I replaced tabs with spaces because if this block is moved, the test/lint/lint-whitespace.sh will fail.

Currently RPC commands are formatted in a way that it's easy to read
and that test/lint/check-rpc-mappings.py can parse it.

To void breaking test/lint/check-rpc-mappings.py script by running
clang-format, RPC command definitions should be disabled for clang-format.
@kostyantyn kostyantyn force-pushed the preserve_format_of_rpc_command_definitions branch from f378b89 to d9d7957 Aug 20, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Aug 20, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #14121 (Index for BIP 157 block filters by jimpo)
  • #13932 (Additional utility RPCs for PSBT by achow101)
  • #13152 ([rpc] Add getnodeaddresses RPC command by chris-belcher)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

scravy
scravy approved these changes Aug 21, 2018
@scravy
Copy link
Contributor

@scravy scravy commented Aug 21, 2018

ACK, looks good to me

@laanwj
Copy link
Member

@laanwj laanwj commented Sep 10, 2018

yes, this makes sense, otherwise clang-format will mess up the tables
utACK d9d7957

@laanwj laanwj merged commit d9d7957 into bitcoin:master Sep 10, 2018
2 checks passed
laanwj added a commit that referenced this issue Sep 10, 2018
d9d7957 Preserve a format of RPC command definitions (Kostiantyn Stepaniuk)

Pull request description:

  Currently, RPC commands are formatted in a way that it's easy to read
  and that `test/lint/check-rpc-mappings.py` can parse it.

  To void breaking `test/lint/check-rpc-mappings.py` script by running
  `clang-format`, RPC command definitions should be disabled for clang-format.

Tree-SHA512: e17d20ec0e6c4e19410198b55687ebbe6fa01654d214d4578cd16c00b872bf8b0b306594a45523685cd2e9d9280702e00471d9366e87954428e8bbeacd8cad60
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants