Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add new regtest ports in man following #10825 ports reattributions #14013

Merged
merged 1 commit into from Sep 4, 2018

Conversation

@ariard
Copy link
Member

@ariard ariard commented Aug 21, 2018

Following #10825, regtest ports for p2p connections and JSON-RPC connections have been remapped from 18333 and 18332 to 18444 and 18443. This change is not documented in the wiki or nowhere else and it's puzzling to guess why your regtest JSON-rpc connections all failed even if you're following the docs.

@fanquake fanquake added the Docs label Aug 21, 2018
@hebasto
Copy link
Member

@hebasto hebasto commented Aug 21, 2018

Manpages are generated from the help outputs. So consider to change the bitcoind -help output rather the bitcoind manpage please.

Loading

@ariard ariard force-pushed the add_new_regtest_ports_manpages branch from 3684942 to ad5247a Aug 22, 2018
@ariard
Copy link
Member Author

@ariard ariard commented Aug 22, 2018

Updated+rebased

Loading

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Aug 22, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #14100 (doc: Change documentation for =0 for non-boolean options by laanwj)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Loading

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Aug 22, 2018

ACK. Could you do the same for checkblockindex and checkmempool, please?

Loading

@ariard ariard force-pushed the add_new_regtest_ports_manpages branch from ad5247a to 26f9609 Aug 23, 2018
@ariard
Copy link
Member Author

@ariard ariard commented Aug 23, 2018

Updated and rebased, checkmempool regtest is 1 right ?

Loading

src/init.cpp Outdated
gArgs.AddArg("-checkblockindex", strprintf("Do a full consistency check for mapBlockIndex, setBlockIndexCandidates, chainActive and mapBlocksUnlinked occasionally. (default: %u)", defaultChainParams->DefaultConsistencyChecks()), true, OptionsCategory::DEBUG_TEST);
gArgs.AddArg("-checkmempool=<n>", strprintf("Run checks every <n> transactions (default: %u)", defaultChainParams->DefaultConsistencyChecks()), true, OptionsCategory::DEBUG_TEST);
gArgs.AddArg("-checkblockindex", strprintf("Do a full consistency check for mapBlockIndex, setBlockIndexCandidates, chainActive and mapBlocksUnlinked occasionally. (default: %u, regtest: 1)", defaultChainParams->DefaultConsistencyChecks()), true, OptionsCategory::DEBUG_TEST);
gArgs.AddArg("-checkmempool=<n>", strprintf("Run checks every <n> transactions (default: %u, regtest: 1)", defaultChainParams->DefaultConsistencyChecks()), true, OptionsCategory::DEBUG_TEST);
Copy link
Member

@MarcoFalke MarcoFalke Aug 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to use (reg)testnetChainParams here instead of hardcoding

Loading

…ions

Add checkmempool and checkblockindex regtest true in doc
@ariard ariard force-pushed the add_new_regtest_ports_manpages branch from 26f9609 to e8c4a1e Aug 23, 2018
@ariard
Copy link
Member Author

@ariard ariard commented Aug 23, 2018

Yes sure! done

Loading

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Aug 23, 2018

utACK e8c4a1e

Loading

@fanquake
Copy link
Member

@fanquake fanquake commented Sep 3, 2018

tACK e8c4a1e

master (68f3c7e):

src/bitcoin-cli -?
-rpcport=<port>
       Connect to JSON-RPC on <port> (default: 8332 or testnet: 18332)

src/bitcoind -? -help-debug
-port=<port>
       Listen for connections on <port> (default: 8333 or testnet: 18333)
-checkblockindex
       Do a full consistency check for mapBlockIndex, setBlockIndexCandidates,
       chainActive and mapBlocksUnlinked occasionally. (default: 0)
-checkmempool=<n>
       Run checks every <n> transactions (default: 0)
-rpcport=<port>
       Listen for JSON-RPC connections on <port> (default: 8332 or testnet:
       18332)

e8c4a1e:

src/bitcoin-cli -?
-rpcport=<port>
       Connect to JSON-RPC on <port> (default: 8332, testnet: 18332, regtest:
       18443)

src/bitcoind -? -help-debug
-port=<port>
       Listen for connections on <port> (default: 8333, testnet: 18333,
       regtest: 18444)
-checkblockindex
       Do a full consistency check for mapBlockIndex, setBlockIndexCandidates,
       chainActive and mapBlocksUnlinked occasionally. (default: 0,
       regtest: 1)
-checkmempool=<n>
       Run checks every <n> transactions (default: 0, regtest: 1)
-rpcport=<port>
       Listen for JSON-RPC connections on <port> (default: 8332, testnet:
       18332, regtest: 18443)

Loading

@fanquake fanquake added this to Mergeable in High-priority for review Sep 3, 2018
@laanwj
Copy link
Member

@laanwj laanwj commented Sep 4, 2018

I think the reason that regtest was never mentioned in docs like this is that it is considered a developer/debug feature, not a user-facing one.
Though, now that option help is no longer translated I don't think it's necessary to be so strict about that anymore here.
utACK e8c4a1e

Loading

@laanwj laanwj merged commit e8c4a1e into bitcoin:master Sep 4, 2018
2 checks passed
Loading
laanwj added a commit that referenced this issue Sep 4, 2018
…ts reattributions

e8c4a1e Add new regtest ports in doc following #10825 ports reattributions (Antoine Riard)

Pull request description:

  Following #10825, regtest ports for p2p connections and JSON-RPC connections have been remapped from 18333 and 18332 to 18444 and 18443. This change is not documented in the wiki or nowhere else and it's puzzling to guess why your regtest JSON-rpc connections all failed even if you're following the docs.

Tree-SHA512: e2a1b9b4059060d9ed0900c1554e124ed69ae3e4648474880795128e77c7324d68aba52e4acda2f47390a9c3d36629b777e3b8c0eb10f0e08a2b120c4119dff3
@fanquake fanquake removed this from Mergeable in High-priority for review Sep 4, 2018
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Mar 17, 2020
…ts reattributions

Summary:
e8c4a1e36969d2ef816d9dfaaee979a8cf6bfffe Add new regtest ports in doc following #10825 ports reattributions (Antoine Riard)

Pull request description:

  Following #10825, regtest ports for p2p connections and JSON-RPC connections have been remapped from 18333 and 18332 to 18444 and 18443. This change is not documented in the wiki or nowhere else and it's puzzling to guess why your regtest JSON-rpc connections all failed even if you're following the docs.

Tree-SHA512: e2a1b9b4059060d9ed0900c1554e124ed69ae3e4648474880795128e77c7324d68aba52e4acda2f47390a9c3d36629b777e3b8c0eb10f0e08a2b120c4119dff3

Backport of Core [[bitcoin/bitcoin#14013 | PR14013]]

Test Plan:
  ninja
  ./bitcoin --help -help-debug
  ./bitcoin-cli --help
Verify changes to help text

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5485
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue May 19, 2020
…ts reattributions

Summary:
e8c4a1e36969d2ef816d9dfaaee979a8cf6bfffe Add new regtest ports in doc following #10825 ports reattributions (Antoine Riard)

Pull request description:

  Following #10825, regtest ports for p2p connections and JSON-RPC connections have been remapped from 18333 and 18332 to 18444 and 18443. This change is not documented in the wiki or nowhere else and it's puzzling to guess why your regtest JSON-rpc connections all failed even if you're following the docs.

Tree-SHA512: e2a1b9b4059060d9ed0900c1554e124ed69ae3e4648474880795128e77c7324d68aba52e4acda2f47390a9c3d36629b777e3b8c0eb10f0e08a2b120c4119dff3

Backport of Core [[bitcoin/bitcoin#14013 | PR14013]]

Test Plan:
  ninja
  ./bitcoin --help -help-debug
  ./bitcoin-cli --help
Verify changes to help text

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5485
Munkybooty added a commit to Munkybooty/dash that referenced this issue Sep 8, 2021
…coin#10825 ports reattributions

e8c4a1e Add new regtest ports in doc following bitcoin#10825 ports reattributions (Antoine Riard)

Pull request description:

  Following bitcoin#10825, regtest ports for p2p connections and JSON-RPC connections have been remapped from 18333 and 18332 to 18444 and 18443. This change is not documented in the wiki or nowhere else and it's puzzling to guess why your regtest JSON-rpc connections all failed even if you're following the docs.

Tree-SHA512: e2a1b9b4059060d9ed0900c1554e124ed69ae3e4648474880795128e77c7324d68aba52e4acda2f47390a9c3d36629b777e3b8c0eb10f0e08a2b120c4119dff3
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants