Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utxoscriptindex #14035

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
6 participants
@mgrychow
Copy link

commented Aug 23, 2018

Yet another attempt to introduce UTxO index by script. Based on #9806 with review remarks and new index framework introduced in #13033 taken into account.

@mgrychow mgrychow force-pushed the mgrychow:utxoscriptindex branch 2 times, most recently Aug 23, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14942 (wallet: Return a ScanResult from CWallet::RescanFromTime by Empact)
  • #14384 (Resolve validationinterface circular dependencies by 251Labs)
  • #14121 (Index for BIP 157 block filters by jimpo)
  • #14111 (index: Create IndexRunner class for activing indexes. by jimpo)
  • #13949 (Introduce MempoolObserver interface to break "policy/fees -> txmempool -> policy/fees" circular dependency by Empact)
  • #13743 (refactor: Replace boost::bind with std::bind by ken2812221)
  • #13088 (Log early messages with -printtoconsole by ajtowns)
  • #10973 (Refactor: separate wallet from node by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

src/rpc/blockchain.cpp Outdated
ScriptPubKeyToUniv(coin.out.scriptPubKey, oScriptPubKey, true);

UniValue o(UniValue::VOBJ);
o.push_back(Pair("confirmations", nConfirmations));

This comment has been minimized.

Copy link
@instagibbs

instagibbs Aug 24, 2018

Member

note: "push_back(Pair" is deprecated in favor of pushKV

This comment has been minimized.

Copy link
@mgrychow

mgrychow Aug 24, 2018

Author

Corrected

@instagibbs

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

Might be wortwhile to update it to using output descriptors, like scantxoutset: https://github.com/bitcoin/bitcoin/blob/master/src/rpc/blockchain.cpp#L2035

@mgrychow

This comment has been minimized.

Copy link
Author

commented Aug 24, 2018

@instagibbs Thanks for the remarks, how about adding support for descriptors in separate PR?

@marcinja

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2018

@mgrychow, I recently started working on an address-based index (not just for UTXOs) at #14053. I can improve my PR quite a bit using your changes to the ValidationInterface. If you separated that change (adding CBlockUndo's) into it's own commit this PR would be a bit cleaner, and I could use it for the address index :)

Anyway, will be reviewing this since it's pretty similar to the PR I just made.

@instagibbs

This comment has been minimized.

Copy link
Member

commented Aug 24, 2018

@mgrychow Not going to bikeshed this PR to death, just noting it in case you've missed it.

Show resolved Hide resolved src/index/utxoscriptindex.cpp
Show resolved Hide resolved src/index/utxoscriptindex.cpp

@mgrychow mgrychow force-pushed the mgrychow:utxoscriptindex branch Nov 13, 2018

@DrahtBot DrahtBot removed the Needs rebase label Nov 13, 2018

@mgrychow mgrychow force-pushed the mgrychow:utxoscriptindex branch to 34c8e8e Nov 13, 2018

@mgrychow

This comment has been minimized.

Copy link
Author

commented Nov 14, 2018

Rebased

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2018

Needs rebase

marcinja added a commit to marcinja/bitcoin that referenced this pull request Jan 22, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Jan 22, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Jan 30, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Jan 30, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 6, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>

marcinja added a commit to marcinja/bitcoin that referenced this pull request Mar 20, 2019

Add CBlockUndo data to BlockConnected callbacks
Changes cherry-picked from bitcoin#14035.

Co-authored-by: Maciej Grychowski <maciej.grychowski@onet.eu>
@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Apr 19, 2019

There hasn't been much activity lately and the patch still needs rebase, so I am closing this for now. Please let me know when you want to continue working on this, so the pull request can be re-opened.

@MarcoFalke MarcoFalke closed this Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.