New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Run unit tests --with-sanitizers=undefined #14036

Merged
merged 2 commits into from Aug 27, 2018

Conversation

Projects
None yet
7 participants
@MarcoFalke
Copy link
Member

MarcoFalke commented Aug 23, 2018

See issue #12691

@MarcoFalke MarcoFalke added the Tests label Aug 23, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1803-travisAsan branch 6 times, most recently from fa108c3 to fa6559e Aug 23, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

DrahtBot commented Aug 23, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #13863 (travis: move script sections to files in .travis/ subject to shellcheck by scravy)
  • #13827 (wip, depends: Add native_nsis to support unicode by ken2812221)
  • #13515 (travis: avoid timeout without saving caches, also enable all qt by ken2812221)
  • #12134 (Build previous releases and run functional tests by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift

This comment has been minimized.

Copy link
Member

practicalswift commented Aug 23, 2018

This is excellent!

Strongest possible concept ACK (assuming we’re not hitting build timeout issues blocking this – that the builds take too long to finish)

@ken2812221

This comment has been minimized.

Copy link
Member

ken2812221 commented Aug 24, 2018

Concept ACK

1 similar comment
@scravy

This comment has been minimized.

Copy link
Contributor

scravy commented Aug 24, 2018

Concept ACK

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1803-travisAsan branch from fa6559e to fa1859f Aug 24, 2018

@MarcoFalke MarcoFalke changed the title travis: Compile with sanitizers and clang in one of the linux jobs travis: Compile --with-sanitizers=undefined --enable-werror Aug 24, 2018

@scravy

This comment has been minimized.

Copy link
Contributor

scravy commented Aug 24, 2018

From the build log:

checking whether we are using Intel C compiler... no
checking whether we are using Sun Studio C compiler... no
checking whether we are using clang C compiler... no
checking whether we are using gcc >= 4 C compiler... yes
checking whether the C++ compiler works... yes
checking whether we are using Intel C++ compiler... no
checking whether we are using Sun Studio C++ compiler... no
checking whether we are using clang C++ compiler... no
checking whether we are using gcc >= 4 C++ compiler... yes

In https://travis-ci.org/bitcoin/bitcoin/jobs/420091638:

Pull Request #14036 travis: Compile with sanitizers and clang in one of the linux jobs

doesn't seem to be using clang at all.

@MarcoFalke

This comment has been minimized.

Copy link
Member

MarcoFalke commented Aug 24, 2018

Yes, it is not possible to set the compiler when building from depends. I will add this back, when it is possible.

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1803-travisAsan branch 2 times, most recently from ffffffe to faa1822 Aug 24, 2018

@MarcoFalke MarcoFalke changed the title travis: Compile --with-sanitizers=undefined --enable-werror travis: Compile with Werror, clang on some linux jobs Aug 24, 2018

@MarcoFalke MarcoFalke closed this Aug 24, 2018

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1803-travisAsan branch Aug 24, 2018

@MarcoFalke MarcoFalke restored the MarcoFalke:Mf1803-travisAsan branch Aug 24, 2018

@MarcoFalke MarcoFalke reopened this Aug 24, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1803-travisAsan branch from faa1822 to fa8b211 Aug 24, 2018

@MarcoFalke MarcoFalke changed the title travis: Compile with Werror, clang on some linux jobs travis: Run unit tests --with-sanitizers=undefined Aug 24, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1803-travisAsan branch 3 times, most recently from b0f261a to fabc443 Aug 25, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1803-travisAsan branch 3 times, most recently from fae1cdd to fa83591 Aug 25, 2018

@MarcoFalke MarcoFalke closed this Aug 25, 2018

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1803-travisAsan branch Aug 25, 2018

@MarcoFalke MarcoFalke restored the MarcoFalke:Mf1803-travisAsan branch Aug 26, 2018

@MarcoFalke MarcoFalke reopened this Aug 26, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1803-travisAsan branch from fa83591 to fa6c882 Aug 26, 2018

@laanwj

This comment has been minimized.

Copy link
Member

laanwj commented Aug 27, 2018

utACK fad8afa

@laanwj laanwj merged commit fad8afa into bitcoin:master Aug 27, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 27, 2018

Merge #14036: travis: Run unit tests --with-sanitizers=undefined
fad8afa travis: Run unit tests --with-sanitizers=undefined (MarcoFalke)
0d00fd5 depends: allow CC/CXX to be overridden during configure (Cory Fields)

Pull request description:

  See issue #12691

Tree-SHA512: 0772e8e037411cb4664270945a0fc9c0c1ed24eeaf5308460baee707868f7b700d8e740a6babb1d02bc818a8a4b71d9e33601ab2cc850ff315755fcf3d79d29e

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1803-travisAsan branch Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment