Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md to linux release tarballs #14037

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
4 participants
@hebasto
Copy link
Member

commented Aug 23, 2018

fix #8160

Gitian building report for 0.17.0rc2:

7d89d7dc3488915ec2380253a69fb3b8f8065592e24c5b2a99a91da30f2142cc  bitcoin-0.17.0-aarch64-linux-gnu-debug.tar.gz
fcb292fd2c4fca88e5cc5a97ee7fa3390d3c7221aada166fe7822d64a2ee9dfa  bitcoin-0.17.0-aarch64-linux-gnu.tar.gz
0ec6f979a823a6b6084d2e80605dffd3ccdda359e8459cebec25092c1087348f  bitcoin-0.17.0-arm-linux-gnueabihf-debug.tar.gz
45af8757a2315125afe2f4d4f276d9b9cf616b8ab814284ce2f82b9a345971d8  bitcoin-0.17.0-arm-linux-gnueabihf.tar.gz
b37b6d9bda864af968dfab6eebb245e75ecc56eb18b139b946270933381ea288  bitcoin-0.17.0-i686-pc-linux-gnu-debug.tar.gz
20c96a5509eeb3e8ec505f18914ef9231beef1fec5e9e1c4b33ec6c6b613d146  bitcoin-0.17.0-i686-pc-linux-gnu.tar.gz
d505888594a04dab2b34ccd6863b8f25eb97d9cb76650e39d93f4d6c09d4c55a  bitcoin-0.17.0-x86_64-linux-gnu-debug.tar.gz
f55b16716c3295e309c816e170911380a5a26e9be3a336b213f2f412f0b159b3  bitcoin-0.17.0-x86_64-linux-gnu.tar.gz
01c6b5ce15b9f3fcdcce96baae14eb04ab2605f2294d333e96b66e004594eea6  src/bitcoin-0.17.0.tar.gz

Release tarball content:

$ tar -tf bitcoin-binaries/0.17.0rc2/bitcoin-0.17.0-x86_64-linux-gnu.tar.gz 
bitcoin-0.17.0/
bitcoin-0.17.0/bin/
bitcoin-0.17.0/bin/bitcoin-cli
bitcoin-0.17.0/bin/bitcoind
bitcoin-0.17.0/bin/bitcoin-qt
bitcoin-0.17.0/bin/bitcoin-tx
bitcoin-0.17.0/bin/test_bitcoin
bitcoin-0.17.0/include/
bitcoin-0.17.0/include/bitcoinconsensus.h
bitcoin-0.17.0/lib/
bitcoin-0.17.0/lib/libbitcoinconsensus.so
bitcoin-0.17.0/lib/libbitcoinconsensus.so.0
bitcoin-0.17.0/lib/libbitcoinconsensus.so.0.0.0
bitcoin-0.17.0/README.md
bitcoin-0.17.0/share/
bitcoin-0.17.0/share/man/
bitcoin-0.17.0/share/man/man1/
bitcoin-0.17.0/share/man/man1/bitcoin-cli.1
bitcoin-0.17.0/share/man/man1/bitcoind.1
bitcoin-0.17.0/share/man/man1/bitcoin-qt.1
bitcoin-0.17.0/share/man/man1/bitcoin-tx.1
@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2018

No more conflicts as of last run.
@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 27, 2018

Thanks for doing this!

It does look like this contains unnecessary changes, making it hard to review. If you want to do miscellaneous refactoring of the build script at the same time that would be better in a separate commit.

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2018

@laanwj

Thanks for doing this!

Thank you for your review.

It does look like this contains unnecessary changes, making it hard to review. If you want to do miscellaneous refactoring of the build script at the same time that would be better in a separate commit.

The refactoring makes the tarball content processing straightforward and visually clear.
Should I remove refactoring changes from this PR or just split the commit into two ones?

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 27, 2018

keeping it in the PR is fine, IMO, just separate into two commits - one that does idempotent refactoring, and one that makes the actual change

@hebasto hebasto force-pushed the hebasto:readme-release-tarballs branch to 8550f1f Aug 27, 2018

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2018

@laanwj I've rethought your words about the refactoring need. I'm agree the refactoring changes are unnecessary regarding this PR goal. They all are removed.

@laanwj

This comment has been minimized.

Copy link
Member

commented Aug 28, 2018

utACK 8550f1f

@laanwj laanwj merged commit 8550f1f into bitcoin:master Aug 31, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 31, 2018

Merge #14037: Add README.md to linux release tarballs
8550f1f Add README.md to linux release tarballs (Hennadii Stepanov)

Pull request description:

  fix #8160

  Gitian building report for 0.17.0rc2:
  ```
  7d89d7dc3488915ec2380253a69fb3b8f8065592e24c5b2a99a91da30f2142cc  bitcoin-0.17.0-aarch64-linux-gnu-debug.tar.gz
  fcb292fd2c4fca88e5cc5a97ee7fa3390d3c7221aada166fe7822d64a2ee9dfa  bitcoin-0.17.0-aarch64-linux-gnu.tar.gz
  0ec6f979a823a6b6084d2e80605dffd3ccdda359e8459cebec25092c1087348f  bitcoin-0.17.0-arm-linux-gnueabihf-debug.tar.gz
  45af8757a2315125afe2f4d4f276d9b9cf616b8ab814284ce2f82b9a345971d8  bitcoin-0.17.0-arm-linux-gnueabihf.tar.gz
  b37b6d9bda864af968dfab6eebb245e75ecc56eb18b139b946270933381ea288  bitcoin-0.17.0-i686-pc-linux-gnu-debug.tar.gz
  20c96a5509eeb3e8ec505f18914ef9231beef1fec5e9e1c4b33ec6c6b613d146  bitcoin-0.17.0-i686-pc-linux-gnu.tar.gz
  d505888594a04dab2b34ccd6863b8f25eb97d9cb76650e39d93f4d6c09d4c55a  bitcoin-0.17.0-x86_64-linux-gnu-debug.tar.gz
  f55b16716c3295e309c816e170911380a5a26e9be3a336b213f2f412f0b159b3  bitcoin-0.17.0-x86_64-linux-gnu.tar.gz
  01c6b5ce15b9f3fcdcce96baae14eb04ab2605f2294d333e96b66e004594eea6  src/bitcoin-0.17.0.tar.gz
  ```
  Release tarball content:
  ```
  $ tar -tf bitcoin-binaries/0.17.0rc2/bitcoin-0.17.0-x86_64-linux-gnu.tar.gz
  bitcoin-0.17.0/
  bitcoin-0.17.0/bin/
  bitcoin-0.17.0/bin/bitcoin-cli
  bitcoin-0.17.0/bin/bitcoind
  bitcoin-0.17.0/bin/bitcoin-qt
  bitcoin-0.17.0/bin/bitcoin-tx
  bitcoin-0.17.0/bin/test_bitcoin
  bitcoin-0.17.0/include/
  bitcoin-0.17.0/include/bitcoinconsensus.h
  bitcoin-0.17.0/lib/
  bitcoin-0.17.0/lib/libbitcoinconsensus.so
  bitcoin-0.17.0/lib/libbitcoinconsensus.so.0
  bitcoin-0.17.0/lib/libbitcoinconsensus.so.0.0.0
  bitcoin-0.17.0/README.md
  bitcoin-0.17.0/share/
  bitcoin-0.17.0/share/man/
  bitcoin-0.17.0/share/man/man1/
  bitcoin-0.17.0/share/man/man1/bitcoin-cli.1
  bitcoin-0.17.0/share/man/man1/bitcoind.1
  bitcoin-0.17.0/share/man/man1/bitcoin-qt.1
  bitcoin-0.17.0/share/man/man1/bitcoin-tx.1
  ```

Tree-SHA512: 2a0c069d6533502a95a83eaba57b9828bddd03ab4a4fc47027b0068c9f04837f107abc448d82c929aa1f45441d2459cf6f2ad74b97a4d953f66dc81031bd521a

@hebasto hebasto deleted the hebasto:readme-release-tarballs branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.