Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Disallow extended encoding for non-witness transactions #14039
BIP144 specifies that transactions without witness should use the legacy encoding, which is currently not enforced.
As all hashes, txids, and weights are always computed over a reserialized version of a transaction, it is mostly harmless to permit extended encoding for non-segwit transactions, but I'd rather strictly follow the BIP.
failing decoderaw test: https://travis-ci.org/bitcoin/bitcoin/jobs/419906176#L2871
referenced this pull request
Aug 24, 2018
To fix the test failure you could try rebasing on fae0400
I have no opinion on this change itself. Is there any evidence of other software using this on the p2p or rpc interface? Also note that Bitcoin Core will already normalize the transaction encoding when relaying txs.