Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow extended encoding for non-witness transactions #14039

merged 1 commit into from Apr 25, 2019
Changes from all commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.


Just for now

Disallow extended encoding for non-witness transactions

  • Loading branch information...
sipa committed Aug 24, 2018
commit bb530efa1872ec963417f61da9a95185c7a7a7d6
@@ -220,6 +220,10 @@ inline void UnserializeTransaction(TxType& tx, Stream& s) {
for (size_t i = 0; i <; i++) {
s >>[i].scriptWitness.stack;
if (!tx.HasWitness()) {
/* It's illegal to encode witnesses when all witness stacks are empty. */
throw std::ios_base::failure("Superfluous witness record");
if (flags) {
/* Unknown flag in the serialization */
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.