Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix accidental trunction from int to bool #14093

Merged

Conversation

Projects
None yet
3 participants
@practicalswift
Copy link
Member

commented Aug 28, 2018

Fix accidental trunction from int to bool.

Context: #14086 (comment)

@fanquake fanquake added the Tests label Aug 28, 2018

src/test/scheduler_tests.cpp Outdated
@@ -54,7 +54,7 @@ BOOST_AUTO_TEST_CASE(manythreads)

boost::mutex counterMutex[10];
int counter[10] = { 0 };
FastRandomContext rng(42);
FastRandomContext rng(true);

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Aug 28, 2018

Member

please use named arguments for literal primitive types. {/* fDeterministic */ true}

This comment has been minimized.

Copy link
@practicalswift

practicalswift Aug 28, 2018

Author Member

Good point! Fixed! :-)

@practicalswift practicalswift force-pushed the practicalswift:truncation-from-int-to-bool branch to 1cc5897 Aug 28, 2018

@practicalswift

This comment has been minimized.

Copy link
Member Author

commented Aug 28, 2018

@MarcoFalke Thanks for reviewing. Feedback addressed. Please re-review :-)

@MarcoFalke MarcoFalke merged commit 1cc5897 into bitcoin:master Aug 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Aug 29, 2018

Merge #14093: tests: Fix accidental trunction from int to bool
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift)

Pull request description:

  Fix accidental trunction from `int` to `bool`.

  Context: #14086 (comment)

Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.