Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix accidental trunction from int to bool #14093

Merged

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Aug 28, 2018

Fix accidental trunction from int to bool.

Context: #14086 (comment)

@fanquake fanquake added the Tests label Aug 28, 2018
@@ -54,7 +54,7 @@ BOOST_AUTO_TEST_CASE(manythreads)

boost::mutex counterMutex[10];
int counter[10] = { 0 };
FastRandomContext rng(42);
FastRandomContext rng(true);
Copy link
Member

@MarcoFalke MarcoFalke Aug 28, 2018

please use named arguments for literal primitive types. {/* fDeterministic */ true}

Copy link
Contributor Author

@practicalswift practicalswift Aug 28, 2018

Good point! Fixed! :-)

@practicalswift practicalswift force-pushed the truncation-from-int-to-bool branch from 7957b7b to 1cc5897 Aug 28, 2018
@practicalswift
Copy link
Contributor Author

@practicalswift practicalswift commented Aug 28, 2018

@MarcoFalke Thanks for reviewing. Feedback addressed. Please re-review :-)

@MarcoFalke MarcoFalke merged commit 1cc5897 into bitcoin:master Aug 29, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Aug 29, 2018
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift)

Pull request description:

  Fix accidental trunction from `int` to `bool`.

  Context: #14086 (comment)

Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
@practicalswift practicalswift deleted the truncation-from-int-to-bool branch Apr 10, 2021
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 14, 2021
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift)

Pull request description:

  Fix accidental trunction from `int` to `bool`.

  Context: bitcoin#14086 (comment)

Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift)

Pull request description:

  Fix accidental trunction from `int` to `bool`.

  Context: bitcoin#14086 (comment)

Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift)

Pull request description:

  Fix accidental trunction from `int` to `bool`.

  Context: bitcoin#14086 (comment)

Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift)

Pull request description:

  Fix accidental trunction from `int` to `bool`.

  Context: bitcoin#14086 (comment)

Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
1cc5897 tests: Fix accidental trunction from int to bool (practicalswift)

Pull request description:

  Fix accidental trunction from `int` to `bool`.

  Context: bitcoin#14086 (comment)

Tree-SHA512: 72d209f892e580afa9c295174c206ea5ba764ff9e03613cd9bc57fd0d7118e895ee44d96db90930a29c0b4de7f51dc00101a1b32ba6b46576d34e089ff5482ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants