Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation: Log FormatStateMessage on ConnectBlock error in ConnectTip #14097

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
5 participants
@MarcoFalke
Copy link
Member

commented Aug 29, 2018

This change additionally logs the validation state on error, which is not logged at all on current master.

Before:

ERROR: ConnectTip(): ConnectBlock ffffff.... failed

After:

ERROR: ConnectTip: ConnectBlock ffffff.... failed, bad-cb-amount (code 16)
@domob1812

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

utACK fa309dc. Thanks for this, I've been puzzled myself quite a couple of times what the actual issue is when debugging errors like that - very useful!

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #9719 (Allow abort of ConnectBlock() when shutdown requested. by rebroad)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Aug 29, 2018

utACK fa309dc

Nice usability improvement by making the error message more meaningful!

@laanwj laanwj merged commit fa309dc into bitcoin:master Aug 29, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Aug 29, 2018

Merge #14097: validation: Log FormatStateMessage on ConnectBlock erro…
…r in ConnectTip

fa309dc validation: Log FormatStateMessage on ConnectBlock error in ConnectTip (MarcoFalke)

Pull request description:

  This change additionally logs the validation state on error, which is not logged at all on current master.

  Before:
  ```
  ERROR: ConnectTip(): ConnectBlock ffffff.... failed
  ```

  After:
  ```
  ERROR: ConnectTip: ConnectBlock ffffff.... failed, bad-cb-amount (code 16)
  ```

Tree-SHA512: e69ee0266772b3f77c0193c4a959c2444bf1a51259bd29d790cf665582b037997e520c8567f70b36362c071dcfe1a8ebd7c0f2286cf1b842df5731960e7e1ba0

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1808-validationLogError branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.