Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add missing locking annotations and locks (g_cs_orphans) #14108

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Aug 30, 2018

Add missing locking annotations and locks.

mapOrphanTransactions is guarded by g_cs_orphans.

@practicalswift practicalswift force-pushed the mapOrphanTransactions-is-guarded-by-g_cs_orphans branch from 5dcd7fd to b602c9b Aug 30, 2018
@practicalswift practicalswift changed the title tests: Add missing locking annotations and locks tests: Add missing locking annotations and locks (g_cs_orphans) Aug 30, 2018
@fanquake fanquake added the Tests label Aug 30, 2018
@laanwj
Copy link
Member

@laanwj laanwj commented Aug 31, 2018

utACK b602c9b

@MarcoFalke MarcoFalke merged commit b602c9b into bitcoin:master Aug 31, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Aug 31, 2018
…orphans)

b602c9b tests: Add missing locking annotations and locks (practicalswift)

Pull request description:

  Add missing locking annotations and locks.

  `mapOrphanTransactions` is guarded by `g_cs_orphans`.

Tree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Jan 17, 2020
…orphans)

Summary:
b602c9b3af tests: Add missing locking annotations and locks (practicalswift)

Pull request description:

  Add missing locking annotations and locks.

  `mapOrphanTransactions` is guarded by `g_cs_orphans`.

Tree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8

Backport of Core PR14108
bitcoin/bitcoin#14108

Test Plan:
  cmake -GNinja .. -DENABLE_WERROR=ON
  ninja check

Also run `build-werror` and `build-tsan` builds.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4967
@practicalswift practicalswift deleted the mapOrphanTransactions-is-guarded-by-g_cs_orphans branch Apr 10, 2021
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 15, 2021
… (g_cs_orphans)

b602c9b tests: Add missing locking annotations and locks (practicalswift)

Pull request description:

  Add missing locking annotations and locks.

  `mapOrphanTransactions` is guarded by `g_cs_orphans`.

Tree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
… (g_cs_orphans)

b602c9b tests: Add missing locking annotations and locks (practicalswift)

Pull request description:

  Add missing locking annotations and locks.

  `mapOrphanTransactions` is guarded by `g_cs_orphans`.

Tree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
… (g_cs_orphans)

b602c9b tests: Add missing locking annotations and locks (practicalswift)

Pull request description:

  Add missing locking annotations and locks.

  `mapOrphanTransactions` is guarded by `g_cs_orphans`.

Tree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
… (g_cs_orphans)

b602c9b tests: Add missing locking annotations and locks (practicalswift)

Pull request description:

  Add missing locking annotations and locks.

  `mapOrphanTransactions` is guarded by `g_cs_orphans`.

Tree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
… (g_cs_orphans)

b602c9b tests: Add missing locking annotations and locks (practicalswift)

Pull request description:

  Add missing locking annotations and locks.

  `mapOrphanTransactions` is guarded by `g_cs_orphans`.

Tree-SHA512: f95104fbef23bd385e754c6bea3c3bdddd8a9c6a68e719d761227c9be1e46ff1316ec050a15a1243218dbab4e8584da6674f4a72f949f54b0a758392f19c83f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants