Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
wallet: Remove unused local variable old_label #14117
@fanquake I do quite a lot of checking using various automated jobs, this includes: custom linting, running static analysers on the code base, running tests under dynamic analysers, spell checking of documentation, compiling under various compilers with a wide range of warning flags enabled, etc, etc. These jobs currently run only against
Ideally these checks would run in Travis (assuming the false positive rate is near zero and the runtime is low): that would make sure these issues don't reach
In order to catch a larger proportion of these issues pre-merge please help reaching that goal by taking a few minutes to review some of these open PRs of mine:
Thanks for helping out!
The C++ Core Guidelines sum up my view on the benefits of mechanical checking over human reviewing for this subclass of issues:
IMO, it would make more sense to do a periodical PR that cleans up these things, grouped together, instead of "just after" a PR.
There's really no hurry to get rid of an unused local variable, no need to immediately open a PR.
We've discussed this before.
Agree with @laanwj. If there was a way to make travis yell at you when there is a "unused local variable" or $some_other_non_critical_but_should_be_cleaned_up_before_the_next_major_release_style_issue, then fix them immediately on master if they slip in for whatever reason.
Otherwise a monthly pull request with all minor fixes (or one right before branch-off every six months) should be enough. Note that you can always keep a local