Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Read reject reasons from debug log, not p2p messages #14119

Merged
merged 1 commit into from Sep 8, 2018

Conversation

Projects
None yet
6 participants
@MarcoFalke
Copy link
Member

commented Aug 31, 2018

For local testing we don't need to rely on p2p messages just to assert a reject reason.

Replace reading p2p messages with reading from the debug log file.

@MarcoFalke MarcoFalke added the Tests label Aug 31, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1808-qaRejectLog branch 4 times, most recently Aug 31, 2018

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1808-qaRejectLog branch to fac3e22 Aug 31, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2018

No more conflicts as of last run.
@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 1, 2018

Concept ACK

@jnewbery

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

tACK fac3e22

@laanwj laanwj merged commit fac3e22 into bitcoin:master Sep 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 8, 2018

Merge #14119: qa: Read reject reasons from debug log, not p2p messages
fac3e22 qa: Read reject reasons from debug log, not p2p messages (MarcoFalke)

Pull request description:

  For local testing we don't need to rely on p2p messages just to assert a reject reason.

  Replace reading p2p messages with reading from the debug log file.

Tree-SHA512: fa59598ecf5e00cfb420ef1892d90aa415501fd882e1c608894dc577b0d00e93a442326d3a9167fef77d26aafbe345b730b49109982ccad68a5942384564a90b
@@ -824,7 +824,7 @@ def run_test(self):
tx.vin.append(CTxIn(COutPoint(b64a.vtx[1].sha256, 0)))
b64a = self.update_block("64a", [tx])
assert_equal(len(b64a.serialize()), MAX_BLOCK_BASE_SIZE + 8)
self.sync_blocks([b64a], success=False, reject_code=1, reject_reason=b'error parsing message')
self.sync_blocks([b64a], success=False, reject_reason='non-canonical ReadCompactSize(): iostream error')

This comment has been minimized.

Copy link
@ken2812221

ken2812221 Sep 8, 2018

Member

This is non-canonical ReadCompactSize(): iostream stream error on Windows. See https://ci.appveyor.com/project/DrahtBot/bitcoin/build/master.972. Is there a way to specify the second variant? Or just discard the message to be non-canonical ReadCompactSize()

Fixed in #14007

This comment has been minimized.

Copy link
@AkioNak

AkioNak Sep 13, 2018

Contributor

FYI
On macOS, this is 'non-canonical ReadCompactSize(): unspecified iostream_category error'.
I think #14007 will also fix this because of discarding the message to be 'non-canonical ReadCompactSize().

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1808-qaRejectLog branch Sep 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.