New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Favor macOS show / hide action in dock menu #14133

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
4 participants
@promag
Copy link
Member

promag commented Sep 2, 2018

Before:

screen shot 2018-09-02 at 19 10 02

After:

screen shot 2018-09-02 at 19 19 01

Note that macOS toggles between Hide and Show.

@fanquake fanquake added the macOS label Sep 2, 2018

@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented Sep 2, 2018

Concept ACK. Having duplicate Show / Hide buttons on macOS has always been a bit confusing.

Happy for this to go in before #14123, as it simplifies testing that PR.

@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented Sep 3, 2018

tACK ee3a494

master (68f3c7e):

master

ee3a494:

14133

@fanquake

This comment has been minimized.

Copy link
Member

fanquake commented Sep 4, 2018

@Sjors or @jonasschnelli want to ack/nack?

@Sjors

This comment has been minimized.

Copy link
Member

Sjors commented Sep 4, 2018

utACK ee3a494, less visual clutter is great

@laanwj laanwj merged commit ee3a494 into bitcoin:master Sep 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 4, 2018

Merge #14133: gui: Favor macOS show / hide action in dock menu
ee3a494 gui: Favor macOS show / hide action in dock menu (João Barbosa)

Pull request description:

  Before:

  <img width="188" alt="screen shot 2018-09-02 at 19 10 02" src="https://user-images.githubusercontent.com/3534524/44959393-5a44c400-aee5-11e8-90f4-9a30f67f7ee2.png">

  After:

  <img width="200" alt="screen shot 2018-09-02 at 19 19 01" src="https://user-images.githubusercontent.com/3534524/44959395-60d33b80-aee5-11e8-9773-1d04d3482115.png">

  Note that macOS toggles between `Hide` and `Show`.

Tree-SHA512: e616fabc5a4689355d924cb99ce33c0d4c6618e858002cef7521dc4783346ff882341cf8d7f667d7fb920a8337373eff37169cddc2da93e48f7710e5c41d0b93

@promag promag deleted the promag:2018-09-mac-showhide branch Sep 4, 2018

@promag

This comment has been minimized.

Copy link
Member

promag commented Sep 4, 2018

Thanks

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Dec 24, 2018

promag added a commit to promag/bitcoin that referenced this pull request Dec 30, 2018

laanwj added a commit that referenced this pull request Jan 3, 2019

Merge #15065: 0.17: GUI Backports #14123 #14133 #14383 #14597
27beb83 qt: All tray menu actions call showNormalIfMinimized (João Barbosa)
c470bbd qt: Use GUIUtil::bringToFront where possible (João Barbosa)
ac73c7d qt: Add GUIUtil::bringToFront (João Barbosa)
0c2fb87 Remove obj_c for macOS Dock icon menu (Hennadii Stepanov)
9034714 Use Qt signal for macOS Dock icon click event (Hennadii Stepanov)
4d4bc37 Remove obj_c for macOS Dock icon setting (Hennadii Stepanov)
d2ed162 Clean systray icon menu for -disablewallet mode (Hennadii Stepanov)
298dc15 gui: Favor macOS show / hide action in dock menu (João Barbosa)

Pull request description:

  Backport #14123 #14133 #14383 and #14597 to 0.17 branch to fix #13606 (comment).

Tree-SHA512: 543c80e7e2130870e801e0c9a69b06b9eea27c288478fc5dddeb662f7f3ec5b56b30916e5a9a629fced3fffcb8be77e2cd155e75cfd0a4392299add9730840f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment