Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: correct GetDifficulty doc after #13288 #14135

Merged
merged 1 commit into from Sep 4, 2018

Conversation

@fanquake
Copy link
Member

@fanquake fanquake commented Sep 3, 2018

chain is no longer passed to GetDifficulty, and we just return 1.0 if no blockindex.

@fanquake fanquake added the Docs label Sep 3, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Sep 3, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #12151 (rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON by promag)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj laanwj merged commit 68bfc0b into bitcoin:master Sep 4, 2018
2 checks passed
laanwj added a commit that referenced this issue Sep 4, 2018
68bfc0b doc: correct GetDifficulty doc after #13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
@fanquake fanquake deleted the get-difficulty-doc branch Sep 4, 2018
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 1, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 1, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 2, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 3, 2021
68bfc0b doc: correct GetDifficulty doc after bitcoin#13288 (fanquake)

Pull request description:

  `chain` is no longer passed to GetDifficulty, and we just return `1.0` if no `blockindex`.

Tree-SHA512: 701375d732f343200c4abfaf9039d5c12b10abff97b022e84564f81b26b5ba552f1eb0c0d0fd5370b29b53319eafcf39773a36e1c2dd04ee77e61c18c7b183fa
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants