Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Net] Switch nPrevNodeCount to vNodesSize #14140

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
5 participants
@pstratem
Copy link
Contributor

commented Sep 3, 2018

These both have the same value, but the variable naming is confusing.

Switch nPrevNodeCount to vNodesSize.
These both have the same value, but the variable naming is confusing.

@fanquake fanquake added the P2P label Sep 3, 2018

@domob1812
Copy link
Contributor

left a comment

utACK 83d5305. Indeed much cleaner for readers of the code!

@fanquake

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

utACK 83d5305

@promag

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

utACK 83d5305.

@laanwj laanwj merged commit 83d5305 into bitcoin:master Sep 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 4, 2018

Merge #14140: [Net] Switch nPrevNodeCount to vNodesSize
83d5305 Switch nPrevNodeCount to vNodesSize. (Patrick Strateman)

Pull request description:

  These both have the same value, but the variable naming is confusing.

Tree-SHA512: 4f645e89efdc69884ff4c8bbcf42e2b35d2733687c0fc6ab3f0797e0141fe23ef9cde8bb6ba422f47a88f554e55a099b1f0b3f47cb9fde12db3d46b9a0041bb0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.