Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove misleading checkpoints comment in CMainParams #14149

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
6 participants
@MarcoFalke
Copy link
Member

commented Sep 4, 2018

This removes the checkpoints comment because it is misleading for two reasons:

Also sort the includes with clang-format, as the file is touched anyway.

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #13311 (Don't edit Chainparams after initialization by jtimon)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@pstratem
Copy link
Contributor

left a comment

utACK checkpoints no longer consider timestamps and the strange transactions comment was always nonsensical

@MarcoFalke MarcoFalke added the Docs label Sep 4, 2018

@promag

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

utACK fab5267.

@fanquake

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

utACK fab5267

@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

utACK fab5267

@laanwj laanwj merged commit fab5267 into bitcoin:master Sep 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 6, 2018

Merge #14149: doc: Remove misleading checkpoints comment in CMainParams
fab5267 doxygen: Remove misleading checkpoints comment in CMainParams (MarcoFalke)

Pull request description:

  This removes the checkpoints comment because it is misleading for two reasons:

  * It shows up in the doxygen documentation of `CMainParams` https://dev.visucore.com/bitcoin/doxygen/class_c_main_params.html
  * The comment refers to "strange transactions" in a block, which are not specified further. Transactions in blocks are always consensus-valid or rejected as consensus-invalid.

  Also sort the includes with `clang-format`, as the file is touched anyway.

Tree-SHA512: b75f38dd0422b9310218307cbaa4dd5afa7579612d7dcdf781b8f25626f79c11e090dbcc83a05571f4418220c1a005f6254a9c461534d517ccecf7f1920be6be

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1809-docCheckpointsCMainParams branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.