Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add disable-wallet section to OSX build instructions, update line in Unix instructions #14153

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
4 participants
@bitstein
Copy link
Contributor

commented Sep 5, 2018

The disable-wallet section was mentioned in the Berkeley DB section of the OSX build instructions, but the section did not actually exist. This PR ports the section from the Unix build instructions.

In this case there is no dependency on Berkeley DB 4.8.

Mining is also possible in disable-wallet mode, but only using the `getblocktemplate` RPC
call not `getwork`.

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Sep 5, 2018

Member

I doubt that such an option even exists: I get unknown command: getwork

This comment has been minimized.

Copy link
@bitstein

bitstein Sep 5, 2018

Author Contributor

Should I add a commit to update that line in both the Unix and OSX build instructions to the following?

Mining is also possible in disable-wallet mode using the `getblocktemplate` RPC call.

This comment has been minimized.

Copy link
@MarcoFalke

MarcoFalke Sep 5, 2018

Member

Right, could make sense to remove it in build-unix.md as well.

Though, shouldn't the configure options be independent of operating system? So maybe a doc shared across all os that describes the configure options could make sense. (no strong opinion on this)

This comment has been minimized.

Copy link
@bitstein

bitstein Sep 5, 2018

Author Contributor

I noticed every operating system has a very difficult structure and format for its build instructions. It would be nice to see that more standardized. In this instance, I had been specifically building on OSX, which made me notice the missing section. I'll make that commit and update the PR title for now.

@bitstein bitstein changed the title Docs: Add disable-wallet section to OSX build instructions Docs: Add disable-wallet section to OSX build instructions, update line in Unix instructions Sep 5, 2018

@fanquake fanquake added the Docs label Sep 5, 2018

@Sjors

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

utACK a6f16f1, although longer term I prefer @MarcoFalke's:

maybe a doc shared across all os that describes the configure options could make sense.

getwork was indeed removed in 0.10

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

utACK e351a16

@fanquake

This comment has been minimized.

Copy link
Member

commented Sep 7, 2018

utACK e351a16

@MarcoFalke MarcoFalke merged commit e351a16 into bitcoin:master Sep 7, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Sep 7, 2018

Merge #14153: Docs: Add disable-wallet section to OSX build instructi…
…ons, update line in Unix instructions

e351a16 Remove reference to deprecated RPC call in build instructions (Michael Goldstein)
a6f16f1 Docs: Add disable-wallet section to OSX build instructions (Michael Goldstein)

Pull request description:

  The `disable-wallet` section was mentioned in the `Berkeley DB` section of the OSX build instructions, but the section did not actually exist. This PR ports the section from the Unix build instructions.

Tree-SHA512: e32f10f3b92307325f2101e89d3e18c89346916e70117c208ad7441170c4aee65b636ea4f7dd1cb0ecf0e800c1aa7c37fa73125e69ecdd539bc862e651b79b16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.