Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Convert fs::filesystem_error messages from local multibyte to utf-8 on Windows #14192

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
5 participants
@ken2812221
Copy link
Member

commented Sep 10, 2018

Before:
default
After:
2

@ken2812221 ken2812221 referenced this pull request Sep 10, 2018

Closed

Filename and command line encoding issue on Windows #13869

11 of 12 tasks complete
@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 10, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #13878 (utils: Add fstream wrapper to allow to pass unicode filename on Windows by ken2812221)
  • #13787 (Test for Windows encoding issue by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 11, 2018

utACK e221368

@laanwj laanwj merged commit e221368 into bitcoin:master Sep 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 13, 2018

Merge #14192: utils: Convert fs::filesystem_error messages from local…
… multibyte to utf-8 on Windows

e221368 utils: Convert fs error messages from multibyte to utf-8 (Chun Kuan Lee)

Pull request description:

  Before:
  ![default](https://user-images.githubusercontent.com/11154118/45318798-8d83f480-b570-11e8-8cbb-c729a54f6b9e.png)
  After:
  ![2](https://user-images.githubusercontent.com/11154118/45318806-91177b80-b570-11e8-9474-a62342c92dbd.png)

Tree-SHA512: 0a598bd159286f6784d117b8a24888b2650d5402d687ab0e8d0849e0c3d53797e266647d8177bb6614307c9598019cd7477311bb9895b1bb52a6bd77b460fda1

@ken2812221 ken2812221 deleted the ken2812221:boost-fs-error-unicode branch Sep 13, 2018

@sipsorcery

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

tACK e221368.

14192_dialog

Note that the directory shown in the dialog does exist but that's a separate problem that is dealt with by #13787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.