Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[psbt]Remove redundant BIP174 test from rpc_psbt.json #14199

Merged
merged 1 commit into from Sep 13, 2018

Conversation

@araspitzu
Copy link

@araspitzu araspitzu commented Sep 11, 2018

There was a duplicate test for SIGNER role inside 'test/functional/data/rpc_psbt.json', namely test number 2 was equal to test number 3 in the array of data for 'signer'. This pull request removes the 3rd (redundant) test.

@araspitzu araspitzu changed the title Remove redundant BIP174 test from rpc_psbt.json [psbt]Remove redundant BIP174 test from rpc_psbt.json Sep 11, 2018
Copy link
Contributor

@ken2812221 ken2812221 left a comment

utACK b6a2533

@fanquake fanquake added the Tests label Sep 11, 2018
@Empact
Copy link
Member

@Empact Empact commented Sep 12, 2018

utACK b6a2533

@laanwj
Copy link
Member

@laanwj laanwj commented Sep 13, 2018

  • verified that these are byte-by-byte the same test

utACK b6a2533

@laanwj laanwj merged commit b6a2533 into bitcoin:master Sep 13, 2018
2 checks passed
laanwj added a commit that referenced this issue Sep 13, 2018
b6a2533 Remove redundant BIP174 test from rpc_psbt.json (araspitzu)

Pull request description:

  There was a duplicate test for SIGNER role inside 'test/functional/data/rpc_psbt.json', namely test number 2 was equal to test number 3 in the array of data for 'signer'. This pull request removes the 3rd (redundant) test.

Tree-SHA512: e2128c93183f2e0acf5247274397c77a962accf95dee3bb6f785494cf3080a3f28ea47d8209e36b3064490c821690d1742c22e0d76370cb1688dcb2ab91d8f57
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 19, 2021
….json

b6a2533 Remove redundant BIP174 test from rpc_psbt.json (araspitzu)

Pull request description:

  There was a duplicate test for SIGNER role inside 'test/functional/data/rpc_psbt.json', namely test number 2 was equal to test number 3 in the array of data for 'signer'. This pull request removes the 3rd (redundant) test.

Tree-SHA512: e2128c93183f2e0acf5247274397c77a962accf95dee3bb6f785494cf3080a3f28ea47d8209e36b3064490c821690d1742c22e0d76370cb1688dcb2ab91d8f57
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 19, 2021
….json

b6a2533 Remove redundant BIP174 test from rpc_psbt.json (araspitzu)

Pull request description:

  There was a duplicate test for SIGNER role inside 'test/functional/data/rpc_psbt.json', namely test number 2 was equal to test number 3 in the array of data for 'signer'. This pull request removes the 3rd (redundant) test.

Tree-SHA512: e2128c93183f2e0acf5247274397c77a962accf95dee3bb6f785494cf3080a3f28ea47d8209e36b3064490c821690d1742c22e0d76370cb1688dcb2ab91d8f57
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 19, 2021
….json

b6a2533 Remove redundant BIP174 test from rpc_psbt.json (araspitzu)

Pull request description:

  There was a duplicate test for SIGNER role inside 'test/functional/data/rpc_psbt.json', namely test number 2 was equal to test number 3 in the array of data for 'signer'. This pull request removes the 3rd (redundant) test.

Tree-SHA512: e2128c93183f2e0acf5247274397c77a962accf95dee3bb6f785494cf3080a3f28ea47d8209e36b3064490c821690d1742c22e0d76370cb1688dcb2ab91d8f57
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants