Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[psbt]Remove redundant BIP174 test from rpc_psbt.json #14199

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
5 participants
@araspitzu
Copy link
Contributor

commented Sep 11, 2018

There was a duplicate test for SIGNER role inside 'test/functional/data/rpc_psbt.json', namely test number 2 was equal to test number 3 in the array of data for 'signer'. This pull request removes the 3rd (redundant) test.

@araspitzu araspitzu changed the title Remove redundant BIP174 test from rpc_psbt.json [psbt]Remove redundant BIP174 test from rpc_psbt.json Sep 11, 2018

@ken2812221
Copy link
Member

left a comment

utACK b6a2533

@fanquake fanquake added the Tests label Sep 11, 2018

@Empact

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

utACK b6a2533

@laanwj

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

  • verified that these are byte-by-byte the same test

utACK b6a2533

@laanwj laanwj merged commit b6a2533 into bitcoin:master Sep 13, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 13, 2018

Merge #14199: [psbt]Remove redundant BIP174 test from rpc_psbt.json
b6a2533 Remove redundant BIP174 test from rpc_psbt.json (araspitzu)

Pull request description:

  There was a duplicate test for SIGNER role inside 'test/functional/data/rpc_psbt.json', namely test number 2 was equal to test number 3 in the array of data for 'signer'. This pull request removes the 3rd (redundant) test.

Tree-SHA512: e2128c93183f2e0acf5247274397c77a962accf95dee3bb6f785494cf3080a3f28ea47d8209e36b3064490c821690d1742c22e0d76370cb1688dcb2ab91d8f57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.