Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Move interfaces/* to libbitcoin_server #14204

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
8 participants
@laanwj
Copy link
Member

commented Sep 12, 2018

Move interfaces/* from libbitcoin_util to libbitcoin_server.

Usage of these is shared between bitcoind and bitcoin-qt. It is unnecessary for them to be linked against the other utilities. Also semantically they belong with the server/node, I think.

build: Move interfaces/* to libbitcoin_server
These are shared between bitcoind and bitcoin-qt. It is unnecessary for
them to be linked against the other utilities.
@ken2812221

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

Concept ACK

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #14111 (index: Create IndexRunner class for activing indexes. by jimpo)
  • #14035 (Utxoscriptindex by mgrychow)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@promag

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

How about multi-process? Are the interface headers enough for the wallet process?

@jnewbery

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

Great! tACK e0664f7

@laanwj

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2018

How about multi-process? Are the interface headers enough for the wallet process?

I'd say we cross that bridge when we have to. For now, this makes sense.

And also in that case, another library might have to be defined that has compilation units shared between the wallet process producer/consumer. Even then these things don't belong in the generic util library.

@jnewbery

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

I'd say we cross that bridge when we have to. For now, this makes sense.

👍 no sense in holding up obvious improvements now for something that may or may not come in the future.

@ryanofsky
Copy link
Contributor

left a comment

utACK e0664f7

@promag

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

Yeap agree! utACK e0664f7.

@laanwj laanwj merged commit e0664f7 into bitcoin:master Sep 12, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Sep 12, 2018

Merge #14204: build: Move interfaces/* to libbitcoin_server
e0664f7 build: Move interfaces/* to libbitcoin_server (Wladimir J. van der Laan)

Pull request description:

  Move interfaces/* from libbitcoin_util to libbitcoin_server.

  Usage of these is shared between `bitcoind` and `bitcoin-qt`. It is unnecessary for them to be linked against the other utilities. Also semantically they belong with the server/node, I think.

Tree-SHA512: f82f3a95d362051c0eb8092520715f77c2c75409d41f9c0fab9a15445ea9e79a2a36b5d00b1f5be09b266584051934a32a8b9b28f783f4d7be78885b4a29a383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.