Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Reorder tests and move most of extended tests up to normal tests #14225

Merged
merged 2 commits into from Sep 16, 2018

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Sep 15, 2018

The travis should run almost all jobs unless it takes really long time, however it does not take too long for now. So it's time for moving it to normal job.

(The test sort is to see how many conflict will this cause, will drop it if there are too many)

The first commit can be reviewed by git diff --color-moved=plain

@fanquake fanquake added the Tests label Sep 15, 2018
@ken2812221 ken2812221 force-pushed the 2018-09-15-tests-reorder branch from 9102cf5 to 6e4d6ed Sep 15, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Sep 15, 2018

Note to reviewers: This pull request conflicts with the following ones:
  • #13746 (-masterdatadir for datadir bootstrapping by kallewoof)
  • #13389 (Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() by n2yen)
  • #12134 (Build previous releases and run functional tests by Sjors)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Sep 15, 2018

utACK 6e4d6ed487fcc65f551cdefc212aca329b6f70cd

@ken2812221
Copy link
Contributor Author

@ken2812221 ken2812221 commented Sep 15, 2018

Update: It seems impossible to run feature_pruning on travis, so I re-disable it.

@ken2812221 ken2812221 force-pushed the 2018-09-15-tests-reorder branch from 008050a to b1409f9 Sep 15, 2018
# vv Tests less than 2m vv
'wallet_basic.py',
'wallet_labels.py',
'feature_block.py',
Copy link
Member

@MarcoFalke MarcoFalke Sep 15, 2018

to be honest, I don't think the reordering matters. for example, feature_block was the third test previously and is now the second test. I think it is most important to have the longest running test as the first test. The order of the remaining ones shouldn't matter much if they are reasonably sorted by run time.

Copy link
Contributor Author

@ken2812221 ken2812221 Sep 16, 2018

You're right. That doesn't take a major effect. Also it seems there are a lot of merge conflicts. Now I only move them to the BASE_SCRIPTS list, not to re-order them.

@ken2812221 ken2812221 force-pushed the 2018-09-15-tests-reorder branch from b1409f9 to d641c29 Sep 16, 2018
Copy link
Contributor

@conscott conscott left a comment

Tested ACK d641c29

@MarcoFalke MarcoFalke merged commit d641c29 into bitcoin:master Sep 16, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Sep 16, 2018
… to normal tests

d641c29 travis: Run feature_dbcrash functional tests in cron job (Chun Kuan Lee)
c0d947d tests: Reorder tests and move most of extended tests up to normal tests (Chun Kuan Lee)

Pull request description:

  The travis should run almost all jobs unless it takes really long time, however it does not take too long for now. So it's time for moving it to normal job.

  (The test sort is to see how many conflict will this cause, will drop it if there are too many)

  The first commit can be reviewed by `git diff --color-moved=plain`

Tree-SHA512: db6bd5b1f19de2f729012adda6ed00ca989071fd40a20710c0ff2579b5bd008edcf7421c1ad56d5f0752354e7df408f58351129d35a1ab7f4a6caa9d315df2ec
@ken2812221 ken2812221 deleted the 2018-09-15-tests-reorder branch Sep 16, 2018
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 15, 2021
…ests up to normal tests

d641c29 travis: Run feature_dbcrash functional tests in cron job (Chun Kuan Lee)
c0d947d tests: Reorder tests and move most of extended tests up to normal tests (Chun Kuan Lee)

Pull request description:

  The travis should run almost all jobs unless it takes really long time, however it does not take too long for now. So it's time for moving it to normal job.

  (The test sort is to see how many conflict will this cause, will drop it if there are too many)

  The first commit can be reviewed by `git diff --color-moved=plain`

Tree-SHA512: db6bd5b1f19de2f729012adda6ed00ca989071fd40a20710c0ff2579b5bd008edcf7421c1ad56d5f0752354e7df408f58351129d35a1ab7f4a6caa9d315df2ec

# Conflicts:
#	.travis/test_06_script.sh
#	test/functional/test_runner.py
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jun 22, 2021
…ests up to normal tests

d641c29 travis: Run feature_dbcrash functional tests in cron job (Chun Kuan Lee)
c0d947d tests: Reorder tests and move most of extended tests up to normal tests (Chun Kuan Lee)

Pull request description:

  The travis should run almost all jobs unless it takes really long time, however it does not take too long for now. So it's time for moving it to normal job.

  (The test sort is to see how many conflict will this cause, will drop it if there are too many)

  The first commit can be reviewed by `git diff --color-moved=plain`

Tree-SHA512: db6bd5b1f19de2f729012adda6ed00ca989071fd40a20710c0ff2579b5bd008edcf7421c1ad56d5f0752354e7df408f58351129d35a1ab7f4a6caa9d315df2ec

# Conflicts:
#	.travis/test_06_script.sh
#	test/functional/test_runner.py
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants