Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Save cache even when build or test fail #14231

Merged
merged 1 commit into from Dec 3, 2018

Conversation

Projects
None yet
4 participants
@ken2812221
Copy link
Member

commented Sep 16, 2018

In current travis setup, the job will terminate immediately if an error occur. There is no chance to save the cache. This was accidentally introduced by #13863. This PR is to fix the issue and travis would save cache on error.

test for build error: https://travis-ci.org/bitcoin/bitcoin/builds/429172128

@fanquake fanquake added the Tests label Sep 16, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@ken2812221 ken2812221 force-pushed the ken2812221:travis-save-cache-on-error branch Sep 16, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2018

Coverage Change (pull 14231) Reference (master)
Lines -0.0088 % 87.0361 %
Functions +0.0000 % 84.1130 %
Branches -0.0180 % 51.5451 %

@ken2812221 ken2812221 force-pushed the ken2812221:travis-save-cache-on-error branch to d3ecc3d Oct 27, 2018

@DrahtBot DrahtBot removed the Needs rebase label Oct 27, 2018

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Dec 3, 2018

Merge bitcoin#14231: travis: Save cache even when build or test fail
d3ecc3d travis: Save cache on build error (Chun Kuan Lee)

Pull request description:

  In current travis setup, the job will terminate immediately if an error occur. There is no chance to save the cache. This was accidentally introduced by bitcoin#13863. This PR is to fix the issue and travis would save cache on error.

  test for build error: https://travis-ci.org/bitcoin/bitcoin/builds/429172128

Tree-SHA512: fb8beb97928e10932c695d1884948bf8972a6501042d5212111fba1f258160d813a4c6cc72e9da78f2acd9518382c21943347b820d8e15b5eb874e7707c928b2

@MarcoFalke MarcoFalke merged commit d3ecc3d into bitcoin:master Dec 3, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ken2812221 ken2812221 deleted the ken2812221:travis-save-cache-on-error branch Dec 3, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

The tests fail, but travis is green: https://travis-ci.org/bitcoin/bitcoin/jobs/466818326#L2966

Not sure if this is related to this pull request?

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Dec 13, 2018

Merge bitcoin#14937: travis: fix travis would always be green even if…
… it fail

fc91c1f Revert "travis: Save cache on build error" (Chun Kuan Lee)

Pull request description:

  The current travis-ci job would fail only if the last command failed. It would be succeed if other commands than the last one fail.

  This PR execute the script in another shell instance, so we should export those variables and bash functions. It would return 1 if the script fail no matter if it's the last command.

  Sorry for ruin the travis ci system in bitcoin#14231

  Test: https://travis-ci.org/ken2812221/bitcoin/jobs/467086010

Tree-SHA512: 4d9d144fe4c7038b4eff6bf8496e821af603d81677142c0884ed52aea6ce3a50150669be4fdad72a5d372456a33a2452d75ec35e8a7ec2bc4bdfbeaeb93e9acb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.