Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor: script improvement #14241

Merged

Conversation

Projects
None yet
6 participants
@ken2812221
Copy link
Member

commented Sep 17, 2018

  • Reduce cache size from 1.55GB to 170MB by disabling whole program optimization.
  • The *.iobj *.ipdb cache is no longer required because of above change.
  • Clearing cache hit stats instead of deleting clcache stats.txt file
  • Enable access time on Windows so clcache would work correctly
  • Reduce max cache size from 2GB to 512MB (Uncompressed)
  • Remove unnecessary boost-interprocess vcpkg package
  • Split some command into multiple lines to make it easier to know what commands do.

@fanquake fanquake added the Tests label Sep 17, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:2018-09-17-appveyor-reduce-cache branch Sep 17, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2018

Reviewers, this pull request conflicts with the following ones:
  • #14372 (msvc: build secp256k1 and leveldb locally by ken2812221)
  • #13787 (Test for Windows encoding issue by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@ken2812221 ken2812221 force-pushed the ken2812221:2018-09-17-appveyor-reduce-cache branch Sep 24, 2018

@DrahtBot DrahtBot added Needs rebase and removed Needs rebase labels Sep 24, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:2018-09-17-appveyor-reduce-cache branch Sep 25, 2018

@DrahtBot DrahtBot removed the Needs rebase label Sep 25, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:2018-09-17-appveyor-reduce-cache branch 3 times, most recently Sep 26, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2018

Coverage Change (pull 14241) Reference (master)
Lines +0.0485 % 87.0361 %
Functions +0.1390 % 84.1130 %
Branches +0.0171 % 51.5451 %

@ken2812221 ken2812221 force-pushed the ken2812221:2018-09-17-appveyor-reduce-cache branch 2 times, most recently Oct 2, 2018

@ken2812221 ken2812221 changed the title appveyor: trivial build cache improvement appveyor: script improvement Oct 2, 2018

@jb55

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2018

@ken2812221 ken2812221 force-pushed the ken2812221:2018-09-17-appveyor-reduce-cache branch Oct 4, 2018

@DrahtBot DrahtBot removed the Needs rebase label Oct 4, 2018

.appveyor.yml Outdated
@@ -27,28 +26,34 @@ install:
- cmd: vcpkg upgrade --no-dry-run

This comment has been minimized.

Copy link
@ras0219-msft

ras0219-msft Oct 5, 2018

It would be better to replace the install+upgrade with

>vcpkg remove --recurse --outdated
>vcpkg install %ALL_PACKAGES%

Otherwise, you'll be rebuilding packages that you no longer use (like boost interprocess).

You should also run ./bootstrap-vcpkg.bat after doing a git pull, because there may be important tool changes.

This comment has been minimized.

Copy link
@ken2812221

ken2812221 Oct 5, 2018

Author Member

Awesome

My original thought is that we could get rid of boost-interprocess by clear the cache, but if we use the command you provide, we don't have to clear the cache anymore. Just have to wait for next boost-interprocess update and it would be removed automatically.

@ken2812221 ken2812221 force-pushed the ken2812221:2018-09-17-appveyor-reduce-cache branch to 59a50c2 Oct 5, 2018

@MarcoFalke MarcoFalke merged commit 59a50c2 into bitcoin:master Oct 8, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Oct 8, 2018

Merge #14241: appveyor: script improvement
59a50c2 appveyor: trivial build cache modifications (Chun Kuan Lee)

Pull request description:

  - Reduce cache size from 1.55GB to 170MB by disabling whole program optimization.
  - The `*.iobj` `*.ipdb` cache is no longer required because of above change.
  - Clearing cache hit stats instead of deleting clcache stats.txt file
  - Enable access time on Windows so clcache would work correctly
  - Reduce max cache size from 2GB to 512MB (Uncompressed)
  - Remove unnecessary `boost-interprocess` vcpkg package
  - Split some command into multiple lines to make it easier to know what commands do.

Tree-SHA512: 070b3ee05cd4323cef6fdab5ca0f223a5aa178f09b64d41fa39d0495f9bf3a387eadd10f5b72a2cd5b6f91579f19f595450fcf0afc05d7c5f6059a79fefaadc0

@ken2812221 ken2812221 deleted the ken2812221:2018-09-17-appveyor-reduce-cache branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.