Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appveyor: script improvement #14241

Merged

Conversation

@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Sep 17, 2018

  • Reduce cache size from 1.55GB to 170MB by disabling whole program optimization.
  • The *.iobj *.ipdb cache is no longer required because of above change.
  • Clearing cache hit stats instead of deleting clcache stats.txt file
  • Enable access time on Windows so clcache would work correctly
  • Reduce max cache size from 2GB to 512MB (Uncompressed)
  • Remove unnecessary boost-interprocess vcpkg package
  • Split some command into multiple lines to make it easier to know what commands do.
@fanquake fanquake added the Tests label Sep 17, 2018
@ken2812221 ken2812221 force-pushed the 2018-09-17-appveyor-reduce-cache branch from afafbc4 to 7b7055c Sep 17, 2018
@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Sep 17, 2018

Reviewers, this pull request conflicts with the following ones:
  • #14372 (msvc: build secp256k1 and leveldb locally by ken2812221)
  • #13787 (Test for Windows encoding issue by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Sep 28, 2018

Coverage Change (pull 14241) Reference (master)
Lines +0.0485 % 87.0361 %
Functions +0.1390 % 84.1130 %
Branches +0.0171 % 51.5451 %

@ken2812221 ken2812221 force-pushed the 2018-09-17-appveyor-reduce-cache branch 2 times, most recently from 9b522c4 to af1dcec Oct 2, 2018
@ken2812221 ken2812221 changed the title appveyor: trivial build cache improvement appveyor: script improvement Oct 2, 2018
@jb55
Copy link
Contributor

@jb55 jb55 commented Oct 4, 2018

@ken2812221 ken2812221 force-pushed the 2018-09-17-appveyor-reduce-cache branch from af1dcec to f01ad1e Oct 4, 2018
.appveyor.yml Outdated
@@ -27,28 +26,34 @@ install:
- cmd: vcpkg upgrade --no-dry-run

It would be better to replace the install+upgrade with

>vcpkg remove --recurse --outdated
>vcpkg install %ALL_PACKAGES%

Otherwise, you'll be rebuilding packages that you no longer use (like boost interprocess).

You should also run ./bootstrap-vcpkg.bat after doing a git pull, because there may be important tool changes.

Copy link
Contributor Author

@ken2812221 ken2812221 Oct 5, 2018

Awesome

My original thought is that we could get rid of boost-interprocess by clear the cache, but if we use the command you provide, we don't have to clear the cache anymore. Just have to wait for next boost-interprocess update and it would be removed automatically.

@ken2812221 ken2812221 force-pushed the 2018-09-17-appveyor-reduce-cache branch from f01ad1e to 59a50c2 Oct 5, 2018
@MarcoFalke MarcoFalke merged commit 59a50c2 into bitcoin:master Oct 8, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Oct 8, 2018
59a50c2 appveyor: trivial build cache modifications (Chun Kuan Lee)

Pull request description:

  - Reduce cache size from 1.55GB to 170MB by disabling whole program optimization.
  - The `*.iobj` `*.ipdb` cache is no longer required because of above change.
  - Clearing cache hit stats instead of deleting clcache stats.txt file
  - Enable access time on Windows so clcache would work correctly
  - Reduce max cache size from 2GB to 512MB (Uncompressed)
  - Remove unnecessary `boost-interprocess` vcpkg package
  - Split some command into multiple lines to make it easier to know what commands do.

Tree-SHA512: 070b3ee05cd4323cef6fdab5ca0f223a5aa178f09b64d41fa39d0495f9bf3a387eadd10f5b72a2cd5b6f91579f19f595450fcf0afc05d7c5f6059a79fefaadc0
@ken2812221 ken2812221 deleted the 2018-09-17-appveyor-reduce-cache branch Oct 8, 2018
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants