New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Remove redundant stopThread() signal #14250

Open
wants to merge 1 commit into
base: master
from

Conversation

6 participants
@hebasto
Contributor

hebasto commented Sep 17, 2018

The QThread::finished signal do this work.

@fanquake fanquake added the GUI label Sep 17, 2018

Show resolved Hide resolved src/qt/bitcoin.cpp
@DrahtBot

This comment has been minimized.

Show comment
Hide comment
@DrahtBot

DrahtBot Sep 18, 2018

Contributor
Reviewers, this pull request conflicts with the following ones:
  • #11625 (Add BitcoinApplication & RPCConsole tests by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Contributor

DrahtBot commented Sep 18, 2018

Reviewers, this pull request conflicts with the following ones:
  • #11625 (Add BitcoinApplication & RPCConsole tests by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake fanquake requested a review from jonasschnelli Sep 18, 2018

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Sep 20, 2018

Member

seems more elegant, utACK 041be34 will test soon.

Member

jonasschnelli commented Sep 20, 2018

seems more elegant, utACK 041be34 will test soon.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Sep 25, 2018

Member

Tested ACK #041be348b0bd96d87eb3d1a2b0edc47538dc9f66
https://bitcoin.jonasschnelli.ch/build/795

Member

jonasschnelli commented Sep 25, 2018

Tested ACK #041be348b0bd96d87eb3d1a2b0edc47538dc9f66
https://bitcoin.jonasschnelli.ch/build/795

@jonasschnelli jonasschnelli removed their request for review Sep 25, 2018

@DrahtBot

This comment has been minimized.

Show comment
Hide comment
@DrahtBot

DrahtBot Sep 28, 2018

Contributor
Coverage Change (pull 14250) Reference (master)
Lines +0.0044 % 87.0361 %
Functions +0.0154 % 84.1130 %
Branches -0.0038 % 51.5451 %
Contributor

DrahtBot commented Sep 28, 2018

Coverage Change (pull 14250) Reference (master)
Lines +0.0044 % 87.0361 %
Functions +0.0154 % 84.1130 %
Branches -0.0038 % 51.5451 %
@hebasto

This comment has been minimized.

Show comment
Hide comment
@hebasto

hebasto Oct 12, 2018

Contributor

@Sjors Could you possibly to review this PR?

Contributor

hebasto commented Oct 12, 2018

@Sjors Could you possibly to review this PR?

@Sjors

This comment has been minimized.

Show comment
Hide comment
@Sjors

Sjors Oct 13, 2018

Member

Definitely looks cleaner, but I'm not sure what to test: quitting the app still works on macOS 10.14 in 041be34, so that's good.

Member

Sjors commented Oct 13, 2018

Definitely looks cleaner, but I'm not sure what to test: quitting the app still works on macOS 10.14 in 041be34, so that's good.

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Oct 17, 2018

Member

Needs more tests (@Sjors, @fanquake, etc.)...

Member

jonasschnelli commented Oct 17, 2018

Needs more tests (@Sjors, @fanquake, etc.)...

@fanquake

This comment has been minimized.

Show comment
Hide comment
@fanquake

fanquake Oct 18, 2018

Member

tACK 041be34

Tested on top of 816fab9. If anyone has extra tests etc that could be run against this please post them here.

Member

fanquake commented Oct 18, 2018

tACK 041be34

Tested on top of 816fab9. If anyone has extra tests etc that could be run against this please post them here.

@fanquake fanquake requested a review from laanwj Oct 18, 2018

@fanquake fanquake added this to Mergeable in High-priority for review Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment