Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Split depends installation instructions per arch #14264

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
5 participants
@MarcoFalke
Copy link
Member

commented Sep 19, 2018

The current depends installation instructions fail on bionic with

E: Unable to locate package g++-4.8-aarch64-linux-gnu
E: Unable to locate package gcc-4.8-aarch64-linux-gnu
E: Unable to locate package g++-4.8-arm-linux-gnueabihf
E: Unable to locate package gcc-4.8-arm-linux-gnueabihf

Also, they fail due to missing dependencies make automake cmake pkg-config python3

Fix this by removing the explicit version and splitting them into common instructions and instructions per linux architecture.

@MarcoFalke MarcoFalke added the Docs label Sep 19, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2018

Fun fact:

git log 000000 -1
error: short SHA1 000000 is ambiguous
hint: The candidates are:
hint:   000000035 commit 2018-06-20 - Obsolete #!/bin/bash shebang
hint:   000000901 commit 2018-09-18 - doc: Split depends installation instructions per arch
fatal: ambiguous argument '000000': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 19, 2018

No more conflicts as of last run.

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1809-docDepends branch 7 times, most recently Sep 19, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2018

Tested that the current instructions work on no fresh and minimal ubuntu/debian due to missing packages or not-found packages.

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1809-docDepends branch 2 times, most recently Sep 19, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Sep 19, 2018

Tested that depends compilation (and cross-compilation) works now with fad16ac14df1190de4c9fa9ee2e5ae89c421f0d3 on debian:9, xenial and bionic.

@MarcoFalke MarcoFalke modified the milestone: 0.17.1 Sep 19, 2018

depends/README.md Outdated

For linux ARM cross compilation:

sudo apt-get install g++-aarch64-linux-gnu binutils-aarch64-linux-gnu

This comment has been minimized.

Copy link
@arowser

arowser Sep 19, 2018

Contributor

line 51 is for aarch64, I guess you should swap with line 55.

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1809-docDepends branch 2 times, most recently Sep 20, 2018

depends/README.md Outdated

sudo apt-get install curl librsvg2-bin libtiff-tools bsdmainutils cmake imagemagick libcap-dev libz-dev libbz2-dev python-setuptools

For Win32/Win64 cross compilation:
#### For Win32/Win64 cross compilation:

This comment has been minimized.

Copy link
@practicalswift

practicalswift Sep 21, 2018

Member
2018-09-19 20:32:54 mdl(pr=14264): depends/README.md:39: MD026 Trailing punctuation in header
depends/README.md Outdated

- see [build-windows.md](../doc/build-windows.md#cross-compilation-for-ubuntu-and-windows-subsystem-for-linux)

For linux (including i386, ARM) cross compilation:
#### For linux (including i386, ARM) cross compilation:

This comment has been minimized.

Copy link
@practicalswift

practicalswift Sep 21, 2018

Member
2018-09-19 20:32:54 mdl(pr=14264): depends/README.md:43: MD026 Trailing punctuation in header
depends/README.md Outdated

For macOS cross compilation:
#### For macOS cross compilation:

This comment has been minimized.

Copy link
@practicalswift

practicalswift Sep 21, 2018

Member
2018-09-19 20:32:54 mdl(pr=14264): depends/README.md:47: MD026 Trailing punctuation in header

@MarcoFalke MarcoFalke force-pushed the MarcoFalke:Mf1809-docDepends branch 2 times, most recently to fad95e8 Sep 21, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2018

Coverage Change (pull 14264) Reference (master)
Lines -0.0706 % 87.0361 %
Functions +0.0000 % 84.1130 %
Branches -0.0483 % 51.5451 %
@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2018

@Sjors I've stolen this from you. Mind to take a look here if it looks right?

@Sjors

This comment has been minimized.

Copy link
Member

commented Oct 4, 2018

It looks OK to me, but only way to know for sure is to try on a fresh machine, which I haven't gotten around to.

@MarcoFalke

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2018

I am going to merge, since the current instructions are broken and I tried this on several fresh machines.

@MarcoFalke MarcoFalke merged commit fad95e8 into bitcoin:master Oct 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

MarcoFalke added a commit that referenced this pull request Oct 4, 2018

Merge #14264: doc: Split depends installation instructions per arch
fad95e8 doc: Split build linux dependencies (MarcoFalke)
0000009 doc: Split depends installation instructions per arch (MarcoFalke)

Pull request description:

  The current depends installation instructions fail on bionic with

  ```
  E: Unable to locate package g++-4.8-aarch64-linux-gnu
  E: Unable to locate package gcc-4.8-aarch64-linux-gnu
  E: Unable to locate package g++-4.8-arm-linux-gnueabihf
  E: Unable to locate package gcc-4.8-arm-linux-gnueabihf
  ```

  Also, they fail due to missing dependencies `make automake cmake pkg-config python3`

  Fix this by removing the explicit version and splitting them into common instructions and instructions per linux architecture.

Tree-SHA512: 25d5efa7450a0b1bbd569f431158f5a25bf4fe34f6adc32ebdfd6b6db9447ce083f555f20ff5b9f7c458864986c15d65219a31a1cd2b18bad9965ece2ea5e3be

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1809-docDepends branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.