Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: Remove deprecated args from hidden args #14272

Merged
merged 1 commit into from Sep 20, 2018

Conversation

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Sep 19, 2018

The args have been deprecated since 0.17 (maybe longer) and since we reject unknown args, there is no need to add deprecated args to the list of hidden args and then hand-craft an error message if a user provides them.

@MarcoFalke MarcoFalke force-pushed the Mf1809-initDeprecatedArgs branch from facdc74 to fa910e4 Sep 19, 2018
@ken2812221
Copy link
Contributor

@ken2812221 ken2812221 commented Sep 19, 2018

utACK fa910e4

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Sep 20, 2018

utACK fa910e4

@laanwj
Copy link
Member

@laanwj laanwj commented Sep 20, 2018

-rpcssl, wow, that one has been gone for a while…

ACK

@scravy
Copy link
Contributor

@scravy scravy commented Sep 20, 2018

utACK fa910e4

1 similar comment
@fanquake
Copy link
Member

@fanquake fanquake commented Sep 20, 2018

utACK fa910e4

@MarcoFalke MarcoFalke merged commit fa910e4 into bitcoin:master Sep 20, 2018
2 checks passed
MarcoFalke added a commit that referenced this issue Sep 20, 2018
fa910e4 init: Remove deprecated args from hidden args (MarcoFalke)

Pull request description:

  The args have been deprecated since 0.17 (maybe longer) and since we reject unknown args, there is no need to add deprecated args to the list of hidden args and then hand-craft an error message if a user provides them.

Tree-SHA512: 3a3191439ab0d7969fb72801d097bd86998524f84b3819380224f746cbe4b0f57beec1ad34744424f6587038035b0ddf418ad13171a8d9c3b97b4f3b7b3222a3
@MarcoFalke MarcoFalke deleted the Mf1809-initDeprecatedArgs branch Sep 20, 2018
@promag
Copy link
Member

@promag promag commented Sep 20, 2018

ACK fa910e4, verified all occurrences of these deprecated args were removed.

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Sep 20, 2018

I think you can also remove -usehd, since it doesn't have any effect from 0.16 onwards.

@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Sep 20, 2018

@jnewbery It is currently used to inform the user of "You can't enable/disable HD on an already existing non-HD/HD wallet". I think it gives users a feeling of assurance that their existing wallet file is indeed hd or non-hd.

@MarcoFalke
Copy link
Member Author

@MarcoFalke MarcoFalke commented Sep 20, 2018

I'll leave the decision whether this can be removed to the wallet-people.

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Sep 20, 2018

wallet-person
paging wallet-people

MarcoFalke added a commit that referenced this issue Sep 26, 2018
7ac911a [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as #14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0
// Check for -socks - as this is a privacy risk to continue, exit here
if (gArgs.IsArgSet("-socks"))
return InitError(_("Unsupported argument -socks found. Setting SOCKS version isn't possible anymore, only SOCKS5 proxies are supported."));
// Check for -tor - as this is a privacy risk to continue, exit here
Copy link
Member

@luke-jr luke-jr Dec 20, 2018

Won't this just yield a warning now?

Copy link
Member Author

@MarcoFalke MarcoFalke Dec 20, 2018

Not that I am aware of

Copy link
Member

@luke-jr luke-jr Dec 20, 2018

If the user has tor=1 in bitcoin.conf, where will the InitError come from?

Copy link
Member Author

@MarcoFalke MarcoFalke Dec 20, 2018

Oh, I was testing src/qt/bitcoin-qt -notor, which gave me and still gives

screenshot from 2018-12-20 20-07-05

deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Apr 20, 2020
Summary:
```
The args have been deprecated since 0.17 (maybe longer) and since we
reject unknown args, there is no need to add deprecated args to the list
of hidden args and then hand-craft an error message if a user provides
them.
```

Backport of core [[bitcoin/bitcoin#14272 | PR14272]].

Test Plan:
  arc lint --everything

  ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5778
ftrader pushed a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue May 19, 2020
Summary:
```
The args have been deprecated since 0.17 (maybe longer) and since we
reject unknown args, there is no need to add deprecated args to the list
of hidden args and then hand-craft an error message if a user provides
them.
```

Backport of core [[bitcoin/bitcoin#14272 | PR14272]].

Test Plan:
  arc lint --everything

  ninja check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5778
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 10, 2021
7ac911a [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as bitcoin#14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0

# Conflicts:
#	src/init.cpp
#	src/wallet/wallet.cpp
#	test/functional/wallet_hd.py
#	test/lint/check-doc.py
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 10, 2021
7ac911a [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as bitcoin#14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0

# Conflicts:
#	src/init.cpp
#	src/wallet/wallet.cpp
#	test/functional/wallet_hd.py
#	test/lint/check-doc.py
rkarthik2k21 added a commit to rkarthik2k21/dash that referenced this issue Aug 9, 2021
Merge bitcoin#14272: init: Remove deprecated args from hidden args

fa910e4 init: Remove deprecated args from hidden args (MarcoFalke)

Pull request description:

  The args have been deprecated since 0.17 (maybe longer) and since we reject unknown args, there is no need to add deprecated args to the list of hidden args and then hand-craft an error message if a user provides them.

Tree-SHA512: 3a3191439ab0d7969fb72801d097bd86998524f84b3819380224f746cbe4b0f57beec1ad34744424f6587038035b0ddf418ad13171a8d9c3b97b4f3b7b3222a3
rkarthik2k21 added a commit to rkarthik2k21/dash that referenced this issue Aug 16, 2021
Merge bitcoin#14272: init: Remove deprecated args from hidden args

fa910e4 init: Remove deprecated args from hidden args (MarcoFalke)

Pull request description:

  The args have been deprecated since 0.17 (maybe longer) and since we reject unknown args, there is no need to add deprecated args to the list of hidden args and then hand-craft an error message if a user provides them.

Tree-SHA512: 3a3191439ab0d7969fb72801d097bd86998524f84b3819380224f746cbe4b0f57beec1ad34744424f6587038035b0ddf418ad13171a8d9c3b97b4f3b7b3222a3
UdjinM6 pushed a commit to dashpay/dash that referenced this issue Aug 17, 2021
…4335)

* Merge 9a3a984

Merge bitcoin#14272: init: Remove deprecated args from hidden args

fa910e4 init: Remove deprecated args from hidden args (MarcoFalke)

Pull request description:

  The args have been deprecated since 0.17 (maybe longer) and since we reject unknown args, there is no need to add deprecated args to the list of hidden args and then hand-craft an error message if a user provides them.

Tree-SHA512: 3a3191439ab0d7969fb72801d097bd86998524f84b3819380224f746cbe4b0f57beec1ad34744424f6587038035b0ddf418ad13171a8d9c3b97b4f3b7b3222a3

* Address review comment
Modified hidden_args in SetupServerArgs()
Removed usehd from list of unsupported/deprecated args

Co-authored-by: MarcoFalke <falke.marco@gmail.com>
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants