Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] Remove -usehd #14282

Merged
merged 2 commits into from Sep 26, 2018
Merged

[wallet] Remove -usehd #14282

merged 2 commits into from Sep 26, 2018

Conversation

@jnewbery
Copy link
Member

@jnewbery jnewbery commented Sep 20, 2018

-usehd is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as #14272)

@DrahtBot
Copy link
Contributor

@DrahtBot DrahtBot commented Sep 20, 2018

No more conflicts as of last run.

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Sep 20, 2018

This will throw even if it is set correctly, e.g. it will throw for a non-hd wallet to set -nousehd.

utACK 25548b2

@jonasschnelli
Copy link
Contributor

@jonasschnelli jonasschnelli commented Sep 20, 2018

utACK 25548b2

1 similar comment
@achow101
Copy link
Member

@achow101 achow101 commented Sep 20, 2018

utACK 25548b2

@fanquake
Copy link
Member

@fanquake fanquake commented Sep 20, 2018

utACK 25548b2

@promag
Copy link
Member

@promag promag commented Sep 21, 2018

This will force users to remove -usehd from configs. Add release note?

BTW Tested ACK 25548b2.

@jnewbery
Copy link
Member Author

@jnewbery jnewbery commented Sep 26, 2018

Add release note?

Done.

I think the code change is ready for merge. It has 5 ACKs.

@promag
Copy link
Member

@promag promag commented Sep 26, 2018

Release note LGTM.

ACK 7ac911a.

@MarcoFalke MarcoFalke merged commit 7ac911a into bitcoin:master Sep 26, 2018
0 of 2 checks passed
MarcoFalke added a commit that referenced this issue Sep 26, 2018
7ac911a [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as #14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0
@jnewbery jnewbery deleted the remove_usehd branch Sep 26, 2018
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this issue Mar 17, 2020
Summary:
7ac911afe7 [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2958 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as #14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0

Backport of Core [[bitcoin/bitcoin#14282 | PR14282]]

Test Plan:
  ninja check
  ninja check-functional

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5488
ftrader added a commit to bitcoin-cash-node/bitcoin-cash-node that referenced this issue May 19, 2020
Summary:
7ac911afe7 [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2958 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as #14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0

Backport of Core [[bitcoin/bitcoin#14282 | PR14282]]

Test Plan:
  ninja check
  ninja check-functional

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5488
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 10, 2021
7ac911a [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as bitcoin#14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0

# Conflicts:
#	src/init.cpp
#	src/wallet/wallet.cpp
#	test/functional/wallet_hd.py
#	test/lint/check-doc.py
Munkybooty added a commit to Munkybooty/dash that referenced this issue Jul 10, 2021
7ac911a [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as bitcoin#14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0

# Conflicts:
#	src/init.cpp
#	src/wallet/wallet.cpp
#	test/functional/wallet_hd.py
#	test/lint/check-doc.py
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants