Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] Remove -usehd #14282

Merged
merged 2 commits into from Sep 26, 2018

Conversation

Projects
None yet
7 participants
@jnewbery
Copy link
Member

commented Sep 20, 2018

-usehd is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as #14272)

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 20, 2018

No more conflicts as of last run.

@MarcoFalke MarcoFalke added the Wallet label Sep 20, 2018

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

This will throw even if it is set correctly, e.g. it will throw for a non-hd wallet to set -nousehd.

utACK 25548b2

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

utACK 25548b2

1 similar comment
@achow101

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

utACK 25548b2

@fanquake

This comment has been minimized.

Copy link
Member

commented Sep 20, 2018

utACK 25548b2

@promag

This comment has been minimized.

Copy link
Member

commented Sep 21, 2018

This will force users to remove -usehd from configs. Add release note?

BTW Tested ACK 25548b2.

@jnewbery

This comment has been minimized.

Copy link
Member Author

commented Sep 26, 2018

Add release note?

Done.

I think the code change is ready for merge. It has 5 ACKs.

@promag

This comment has been minimized.

Copy link
Member

commented Sep 26, 2018

Release note LGTM.

ACK 7ac911a.

@MarcoFalke MarcoFalke merged commit 7ac911a into bitcoin:master Sep 26, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

MarcoFalke added a commit that referenced this pull request Sep 26, 2018

Merge #14282: [wallet] Remove -usehd
7ac911a [docs] Add release notes for removing `-usehd` (John Newbery)
25548b2 [wallet] Remove -usehd (John Newbery)

Pull request description:

  `-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as #14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0

@jnewbery jnewbery deleted the jnewbery:remove_usehd branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.