[wallet] Remove addwitnessaddress #14296
addwitnessaddress is deprecated. Replace the call to addwitnessaddress with a call to getnewaddress(address_type='p2sh-segwit')
addwitnessaddress is deprecated. Remove the call to that RPC from wallet_dump.py and improve testing of all types of address (legacy, p2sh-segwit and bech32)
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke added a commit that referenced this issue
Oct 24, 2018
2b91e42 [docs] Add release note for removing getwitnessaddress (John Newbery) ebec90a [wallet] Remove deprecated addwitnessaddress RPC method (John Newbery) 07e3f58 [test] Remove deprecated addwitnessaddress from feature_segwit.py (John Newbery) 82f2fa0 [test] Remove deprecated addwitnessaddress from wallet_bumpfee.py (John Newbery) 9d7ee18 [test] Remove deprecated addwitnessaddress from p2p_compactblocks.py (John Newbery) 3cf77f0 [tests] Remove deprecated addwitnessaddress call from wallet_dump.py (John Newbery) bdefc97 [tests] Remove deprecated addwitnessaddress call from feature_nulldummy (John Newbery) 67d7d67 [test] Fix flake8 warnings in tests (John Newbery) Pull request description: Fully removes the `addwitnessaddress` RPC method, which was deprecated in V0.17 Tree-SHA512: 8fa8a2a721a81262fbdedbe1cef031e6a07aa6abbc9760dbc62738fc4f688b44bd737d0f3cdb1aec046866a6395befbfecde0f34e76a99e11d3cf566cad1d0de
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.