Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Run more tests with wallet disabled #14324

Merged
merged 1 commit into from Oct 8, 2018

Conversation

Projects
None yet
4 participants
@MarcoFalke
Copy link
Member

commented Sep 25, 2018

Instead of skipping the whole test, only skip the wallet specific section of a test if the wallet is not compiled in. This is mostly an indentation change, so can be reviewed with --ignore-all-space.

@fanquake fanquake added the Tests label Sep 25, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2018

Reviewers, this pull request conflicts with the following ones:
  • #13621 (Check for datadir after the config files were read by Flowdalic)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@jamesob
Copy link
Member

left a comment

Nice! utACK faa4043

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2018

Coverage Change (pull 14324) Reference (master)
Lines +0.0000 % 87.0361 %
Functions +0.0154 % 84.1130 %
Branches -0.0047 % 51.5451 %

@MarcoFalke MarcoFalke merged commit faa4043 into bitcoin:master Oct 8, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

MarcoFalke added a commit that referenced this pull request Oct 8, 2018

Merge #14324: qa: Run more tests with wallet disabled
faa4043 qa: Run more tests with wallet disabled (MarcoFalke)

Pull request description:

  Instead of skipping the whole test, only skip the wallet specific section of a test if the wallet is not compiled in. This is mostly an indentation change, so can be reviewed with `--ignore-all-space`.

Tree-SHA512: 5941a8b6b00dca5cf9438c5f6f010ba812115188a69e427d7ade4c1ab8cfe7a57c73daf52c66235dbb24b1cd9ab7c7a17c49bc23d931e041b605d79116a71f66

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1809-qaWalletNo branch Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.