Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitian] use versioned unsigned tarballs instead of generically named ones #14325

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
6 participants
@achow101
Copy link
Member

commented Sep 26, 2018

Instead of re-naming the tarballs used for the code signing step to the generically named tarball that is used, keep the versioned naming. Only copy them to the correct filename when they are needed at build time.

This makes it easier to handle situations when multiple different releases are being built simultaneously as the version that the code signatures are applied to will actually be the correct version and not require a rebuild to get the correct tarball.

[gitian] use versioned unsigned tarballs instead of generically named…
… ones

Instead of re-naming the tarballs used for the code signing step to the generically
named tarball that is used, keep the versioned naming. Only copy them to the
correct filename when they are needed at build time.

@fanquake fanquake requested a review from theuni Sep 27, 2018

@ken2812221

This comment has been minimized.

Copy link
Member

commented Sep 27, 2018

Concept ACK.

How about moving them all to bitcoin-binaries and copying them to gitian-builder/inputs while signing?

@theuni

theuni approved these changes Sep 27, 2018

Copy link
Member

left a comment

utACK d813266. Agree with ken2812221, that's similar to what I do locally. This looks fine too though.

@fanquake

This comment has been minimized.

Copy link
Member

commented Sep 28, 2018

utACK d813266

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2018

Coverage Change (pull 14325) Reference (master)
Lines +0.0088 % 87.0361 %
Functions +0.0154 % 84.1130 %
Branches -0.0047 % 51.5451 %

@laanwj laanwj merged commit d813266 into bitcoin:master Oct 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Oct 1, 2018

Merge #14325: [gitian] use versioned unsigned tarballs instead of gen…
…erically named ones

d813266 [gitian] use versioned unsigned tarballs instead of generically named ones (Andrew Chow)

Pull request description:

  Instead of re-naming the tarballs used for the code signing step to the generically named tarball that is used, keep the versioned naming. Only copy them to the correct filename when they are needed at build time.

  This makes it easier to handle situations when multiple different releases are being built simultaneously as the version that the code signatures are applied to will actually be the correct version and not require a rebuild to get the correct tarball.

Tree-SHA512: 434f721485521c6f7487038705a5d2e48ac2eb79cfad5f92a93b7ea9c91e1fb33702ce7aeed4d840c61ec43e808af5cc15a553b6e16e2ed1d7ac697485019204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.