Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doxygen: Fix member comments #14331

Merged
merged 1 commit into from Oct 1, 2018

Conversation

Projects
None yet
6 participants
@MarcoFalke
Copy link
Member

commented Sep 26, 2018

Trailing comments must be indicted with the caret //!<.

Not all places do this right now, see for example https://dev.visucore.com/bitcoin/doxygen/txmempool_8h.html#a2bc6653552b5871101b6cbefdbaf251f, but they can be fixed with an almost-scripted-diff:

sed -i --regexp-extended -e 's/((,|;) *\/\/!) /\1< /g' $(git grep --extended-regexp -l  '(,|;)\s*//!\s')

(Same as [doxygen] Fix member comments #7793)

@MarcoFalke MarcoFalke added the Docs label Sep 26, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2018

Reviewers, this pull request conflicts with the following ones:
  • #11413 ([wallet] [rpc] sendtoaddress/sendmany: Add explicit feerate option by kallewoof)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@jamesob

This comment has been minimized.

Copy link
Member

commented Sep 27, 2018

utACK fa69ac7

@251Labs

This comment has been minimized.

Copy link
Contributor

commented Sep 27, 2018

utACK fa69ac7

1 similar comment
@Empact

This comment has been minimized.

Copy link
Member

commented Sep 27, 2018

utACK fa69ac7

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Sep 28, 2018

Coverage Change (pull 14331) Reference (master)
Lines -0.0309 % 87.0361 %
Functions +0.0926 % 84.1130 %
Branches -0.0445 % 51.5451 %
@promag

This comment has been minimized.

Copy link
Member

commented Sep 29, 2018

utACK fa69ac7.

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Oct 1, 2018

Merge bitcoin#14331: doxygen: Fix member comments
fa69ac7 doxygen: Fix member comments (MarcoFalke)

Pull request description:

  Trailing comments must be indicted with the caret `//!<`.

  Not all places do this right now, see for example https://dev.visucore.com/bitcoin/doxygen/txmempool_8h.html#a2bc6653552b5871101b6cbefdbaf251f, but they can be fixed with an almost-scripted-diff:

  ```
  sed -i --regexp-extended -e 's/((,|;) *\/\/!) /\1< /g' $(git grep --extended-regexp -l  '(,|;)\s*//!\s')
  ```

  (Same as  [doxygen] Fix member comments bitcoin#7793)

Tree-SHA512: 451077008353ccc6fcc795f34094b2d022feb7a171b562a07ba4de0dcb0aebc137e12b03970764bd81e2da386751d042903db4c4831900f43c0cfde804c81b2b

@MarcoFalke MarcoFalke merged commit fa69ac7 into bitcoin:master Oct 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MarcoFalke MarcoFalke deleted the MarcoFalke:Mf1809-doxygenMembers branch Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.