Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Benchmark to test input de-duplication worst case #14400

Merged

Conversation

Projects
None yet
6 participants
@JeremyRubin
Copy link
Contributor

commented Oct 5, 2018

Because there are now 2PRs referencing this benchmark commit, we may as well add it independently as it is worth landing the benchmark even if neither patch is accepted.

#14397
#14387

@MarcoFalke MarcoFalke added the Tests label Oct 5, 2018

@jamesob

This comment has been minimized.

Copy link
Member

commented Oct 5, 2018

Concept ACK

@JeremyRubin JeremyRubin force-pushed the JeremyRubin:benchmark-reject-duplicate-inputs branch from 90b3b22 to e1ed29f Oct 5, 2018

@DrahtBot

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2018

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #14397 (Faster duplicate input check in CheckTransaction (alternative to #14387) by sipa)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@JeremyRubin JeremyRubin force-pushed the JeremyRubin:benchmark-reject-duplicate-inputs branch from e1ed29f Oct 6, 2018

@JeremyRubin JeremyRubin force-pushed the JeremyRubin:benchmark-reject-duplicate-inputs branch 5 times, most recently Nov 24, 2018

@JeremyRubin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 25, 2018

@MarcoFalke rebased, clang-formatted, etc.

failure is unrelated to this PR now (one of the PBST tests)

@MarcoFalke
Copy link
Member

left a comment

Squash the fixup, so all commits compile?

Show resolved Hide resolved src/bench/duplicate_inputs.cpp Outdated

@JeremyRubin JeremyRubin force-pushed the JeremyRubin:benchmark-reject-duplicate-inputs branch Nov 25, 2018

@JeremyRubin JeremyRubin force-pushed the JeremyRubin:benchmark-reject-duplicate-inputs branch to e4eee7d Nov 25, 2018

@JeremyRubin

This comment has been minimized.

Copy link
Contributor Author

commented Nov 25, 2018

should be ready to merge now, pending integration tests.

Thanks!

@jb55

This comment has been minimized.

Copy link
Contributor

commented Nov 25, 2018

MarcoFalke added a commit to MarcoFalke/bitcoin that referenced this pull request Nov 25, 2018

Merge bitcoin#14400: Add Benchmark to test input de-duplication worst…
… case

e4eee7d Add Benchmark to test input de-duplication worst case (Jeremy Rubin)

Pull request description:

  Because there are now 2PRs referencing this benchmark commit, we may as well add it independently as it is worth landing the benchmark even if neither patch is accepted.

  bitcoin#14397
  bitcoin#14387

Tree-SHA512: 4d947323c02297b0d8f5871f9e7cc42488c0e1792a8b10dc174a25f4dd53da8146fd276949a5dbacf4083f0c6a7235cb6f21a8bc35caa499bc2508f8a048b987

@MarcoFalke MarcoFalke merged commit e4eee7d into bitcoin:master Nov 25, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.