New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX dmg issue (10.12 to 10.14) #14416

Open
wants to merge 1 commit into
base: master
from

Conversation

5 participants
@jonasschnelli
Member

jonasschnelli commented Oct 6, 2018

This seems to fix the macOS 10.12+ DMG issue in conjunction with Gitian on Bionic

@jonasschnelli jonasschnelli added the macOS label Oct 6, 2018

@laanwj laanwj added this to Blockers in High-priority for review Oct 18, 2018

@jonasschnelli jonasschnelli changed the title from [WIP] fix OSX dmg issue (10.12 to 10.14) to Fix OSX dmg issue (10.12 to 10.14) Oct 19, 2018

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli

jonasschnelli Oct 19, 2018

Member

Figured out the issue. It seems to be the python binary string option for the WindowBounds.

Gitian Build:
https://bitcoin.jonasschnelli.ch/build/852

Please test via you own Gitian Build (@fanquake, @Sjors, @ken2812221).

Removed WIP tag.

Member

jonasschnelli commented Oct 19, 2018

Figured out the issue. It seems to be the python binary string option for the WindowBounds.

Gitian Build:
https://bitcoin.jonasschnelli.ch/build/852

Please test via you own Gitian Build (@fanquake, @Sjors, @ken2812221).

Removed WIP tag.

@promag

This comment has been minimized.

Show comment
Hide comment
@promag

promag Oct 19, 2018

Member

Tested ACK 898b7c3 on macOS 10.14 with @jonasschnelli build.

Member

promag commented Oct 19, 2018

Tested ACK 898b7c3 on macOS 10.14 with @jonasschnelli build.

@MarcoFalke

This comment has been minimized.

Show comment
Hide comment
@MarcoFalke

MarcoFalke Oct 20, 2018

Member

Could change the subject of the commit to something more meaningful?

Member

MarcoFalke commented Oct 20, 2018

Could change the subject of the commit to something more meaningful?

@jonasschnelli

This comment has been minimized.

Show comment
Hide comment
@jonasschnelli
Member

jonasschnelli commented Oct 20, 2018

@MarcoFalke: fixed.

@DrahtBot

This comment has been minimized.

Show comment
Hide comment
@DrahtBot

DrahtBot Oct 21, 2018

Contributor

Gitian builds for commit 5c25409 (master):

Gitian builds for commit 73cb922 (master and this pull):

Contributor

DrahtBot commented Oct 21, 2018

Gitian builds for commit 5c25409 (master):

Gitian builds for commit 73cb922 (master and this pull):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment