Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksum in gitian build scripts for ossl #14433

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
7 participants
@TheCharlatan
Copy link
Contributor

commented Oct 8, 2018

This adds a checksum in the gitian build script to make sure that ossl tool and theuni's patch matches what is expected. Also changes the url to use https.

@practicalswift

This comment has been minimized.

Copy link
Member

commented Oct 9, 2018

Concept ACK

Good catch!

subprocess.check_call(['wget', '-N', '-P', 'inputs', 'https://bitcoincore.org/cfields/osslsigncode-Backports-to-1.7.1.patch'])
subprocess.check_output(["echo 'a8c4e9cafba922f89de0df1f2152e7be286aba73f78505169bc351a7938dd911 inputs/osslsigncode-Backports-to-1.7.1.patch' | sha256sum -c"], shell=True)
subprocess.check_output(["echo 'f9a8cdb38b9c309326764ebc937cba1523a3a751a7ab05df3ecc99d18ae466c9 inputs/osslsigncode-1.7.1.tar.gz' | sha256sum -c"], shell=True)

This comment has been minimized.

Copy link
@ken2812221

ken2812221 Oct 9, 2018

Member

check_call?

This comment has been minimized.

Copy link
@TheCharlatan

TheCharlatan Oct 9, 2018

Author Contributor

I think it does not terminate if you use check_call instead.

This comment has been minimized.

Copy link
@laanwj

laanwj Jan 9, 2019

Member

I'm not sure I understand why check_call wouldn't work here (or would hang). This is ignoring the result so the check_output call does the same as check_call except for swallowing stdout. In the case of check_call the output would go to the caller process' stdout.

This comment has been minimized.

Copy link
@TheCharlatan

TheCharlatan Jan 9, 2019

Author Contributor

You are right, I force-pushed a change to check_call .

@MarcoFalke

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

Could do the same for the manual instructions: https://github.com/bitcoin/bitcoin/pull/14799/files#r236341949

@TheCharlatan TheCharlatan force-pushed the TheCharlatan:osslChecksum branch from 06bd2b0 Jan 9, 2019

@MarcoFalke

This comment has been minimized.

@TheCharlatan TheCharlatan force-pushed the TheCharlatan:osslChecksum branch Jan 9, 2019

@TheCharlatan

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

Force-pushed to update release doc as well.

Add checksum in gitian build scripts for ossl
This adds a checksum in the gitian build script to make sure that
ossl tool and theuni's patch matches what is expected. Also changes
the url to use https and adds the same instructions to the release docs.

@TheCharlatan TheCharlatan force-pushed the TheCharlatan:osslChecksum branch to 03b8596 Jan 9, 2019

@DrahtBot DrahtBot removed the Needs rebase label Jan 9, 2019

@laanwj

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

utACK 03b8596

@laanwj laanwj merged commit 03b8596 into bitcoin:master Jan 15, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

laanwj added a commit that referenced this pull request Jan 15, 2019

Merge #14433: Add checksum in gitian build scripts for ossl
03b8596 Add checksum in gitian build scripts for ossl (TheCharlatan)

Pull request description:

  This adds a checksum in the gitian build script to make sure that ossl tool and theuni's patch matches what is expected. Also changes the url to use https.

Tree-SHA512: bd25acda1c7d9ca94e710bdfa915d20810101e10b0c68913a00fcb0eada25cdc2d59f7efebc822e07dea7eaab058024e6c53031883ded0ecf9f08212e50a25b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.