Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Fix QCompleter popup regression #14450

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
5 participants
@hebasto
Copy link
Member

commented Oct 9, 2018

The PR #8129 has introduced a regression with the QCompleter popup in the Debug window.

How to reproduce:

  1. open the Debug window;
  2. go to the 'Console' tab;
  3. start writing some RPC command and try to pick it from the list using arrow keys, press Enter.

Note that the popup used to display completions is not being closed. To close it they should mouse click somewhere outside of the popup.

The wrong behaviour of the QCompleter popup is observed on Linux Mint 19 and Windows 10.
This PR fixes this regression.

Refs:

@fanquake fanquake added the GUI label Oct 9, 2018

@promag

This comment has been minimized.

Copy link
Member

commented Oct 9, 2018

Tested ACK b7df768 on Windows 10.

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2018

@Sjors Would you mind to review this PR?

@Sjors

This comment has been minimized.

Copy link
Member

commented Oct 13, 2018

Tested b7df768 on macOS 10.14 and 5.11.2. It fixes the bug, but introduces a new one: commands get duplicated.
schermafbeelding 2018-10-13 om 15 36 06

Fix QCompleter popup regression
The PR #8129 has introduced a regression with the QCompleter popup in
the Debug window.

How to reproduce:
  1) open the Debug window;
  2) go to the 'Console' tab;
  3) start writing some rpc command and try to pick it from the list
using arrow keys, press Enter.
Note that the popup used to display completions is not being closed. To
close it they should mouse click somewhere outside of the popup.

@hebasto hebasto force-pushed the hebasto:20181009-console-autocomplete branch to 081cc02 Oct 13, 2018

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2018

@Sjors
Thank you for your review.
Fixed. Please re-review.

@Sjors

This comment has been minimized.

Copy link
Member

commented Oct 14, 2018

tACK 081cc02 for macOS 10.14 / QT 5.11.2. Needs retesting on Windows.

@hebasto

This comment has been minimized.

Copy link
Member Author

commented Oct 16, 2018

@promag Would you mind re-reviewing this PR?

@jonasschnelli

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

Tested ACK 081cc02

@jonasschnelli jonasschnelli merged commit 081cc02 into bitcoin:master Oct 17, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jonasschnelli added a commit that referenced this pull request Oct 17, 2018

Merge #14450: qt: Fix QCompleter popup regression
081cc02 Fix QCompleter popup regression (Hennadii Stepanov)

Pull request description:

  The PR #8129 has introduced a regression with the `QCompleter` popup in the Debug window.

  How to reproduce:

  1.  open the Debug window;
  2.  go to the 'Console' tab;
  3.  start writing some RPC command and try to pick it from the list using arrow keys, press Enter.

  Note that the popup used to display completions is not being closed. To close it they should mouse click somewhere outside of the popup.

  The wrong behaviour of the `QCompleter` popup is observed on Linux Mint 19 and Windows 10.
  This PR fixes this regression.

  Refs:

  - #7613
  - #7772
  - #8129

Tree-SHA512: f3ba8d08e1c07619d4ef307544306b57be43e4e726770976cf0c2af95082bd66e2eefe8aabb9a3fad0601cd9e6e4dea0459b6a63eba512023234feb308484655

@hebasto hebasto deleted the hebasto:20181009-console-autocomplete branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.