Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: unbreak make clean #14455

Merged
merged 1 commit into from Oct 10, 2018
Merged

Conversation

@jamesob
Copy link
Member

@jamesob jamesob commented Oct 10, 2018

My preferred alternative to #14440 (I'm too lazy to review an entire file move). This just applies a .log suffix addition to all BITCOIN_TESTS files for the purposes of cleaning, and thus doesn't erroneously remove test/scriptnum10.h.

@Empact
Copy link
Member

@Empact Empact commented Oct 10, 2018

Tested ACK a48e44b - this adds a *.log removal for every entry in BITCOIN_TESTS, which seems good to me.

@murrayn
Copy link
Contributor

@murrayn murrayn commented Oct 10, 2018

tACK a48e44b

@fanquake
Copy link
Member

@fanquake fanquake commented Oct 10, 2018

tACK a48e44b

./autogen.sh && ./configure && make check -j6
make clean

MarcoFalke added a commit to MarcoFalke/bitcoin-core that referenced this issue Oct 10, 2018
a48e44b Fix CLEAN_BITCOIN_TEST to remove .log files for all BITCOIN_TESTS files (James O'Beirne)

Pull request description:

  My preferred alternative to bitcoin#14440 (I'm too lazy to review an entire file move). This just applies a `.log` suffix addition to all `BITCOIN_TESTS` files for the purposes of cleaning, and thus doesn't erroneously remove test/scriptnum10.h.

Tree-SHA512: 06a0d9fb2c4851f4e74215aa4bca9cf81f49787f16c46b0172e5c1cf18ca744d747c5b0c1564cac433e0dea29b0afabd2d95f0f58a0157d1e05b2b7cb7800e00
@MarcoFalke MarcoFalke merged commit a48e44b into bitcoin:master Oct 10, 2018
2 checks passed
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 17, 2021
a48e44b Fix CLEAN_BITCOIN_TEST to remove .log files for all BITCOIN_TESTS files (James O'Beirne)

Pull request description:

  My preferred alternative to bitcoin#14440 (I'm too lazy to review an entire file move). This just applies a `.log` suffix addition to all `BITCOIN_TESTS` files for the purposes of cleaning, and thus doesn't erroneously remove test/scriptnum10.h.

Tree-SHA512: 06a0d9fb2c4851f4e74215aa4bca9cf81f49787f16c46b0172e5c1cf18ca744d747c5b0c1564cac433e0dea29b0afabd2d95f0f58a0157d1e05b2b7cb7800e00
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants