Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Stop node before removing the notification file #14465

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
6 participants
@ken2812221
Copy link
Member

commented Oct 11, 2018

Stop node before removing the notification file to make sure the command has been terminated. After then we could removing those files safely and do not receive any permission error. (See #14446)

The permission error is Windows specific, documented in python doc:

On Windows, attempting to remove a file that is in use causes an exception to be raised

See https://docs.python.org/3/library/os.html#os.remove

@promag

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

ACK. Have you checked for other cases?

@ken2812221

This comment has been minimized.

Copy link
Member Author

commented Oct 11, 2018

Have you checked for other cases?

Yes, but still in investigation.

@meshcollider

This comment has been minimized.

Copy link
Member

commented Oct 11, 2018

LGTM, utACK ca6d86c

@sipa

This comment has been minimized.

Copy link
Member

commented Oct 12, 2018

utACK

@conscott
Copy link
Contributor

left a comment

Possible other case in the mempool persist test ? Although in this case, removing an active file is intentional.

@fanquake fanquake requested a review from MarcoFalke Oct 18, 2018

@sipa sipa merged commit ca6d86c into bitcoin:master Oct 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

sipa added a commit that referenced this pull request Oct 19, 2018

Merge #14465: tests: Stop node before removing the notification file
ca6d86c tests: Stop node before removing the notification file (Chun Kuan Lee)

Pull request description:

  Stop node before removing the notification file to make sure the command has been terminated. After then we could removing those files safely and do not receive any permission error. (See #14446)

  The permission error is Windows specific, documented in python doc:
  >On Windows, attempting to remove a file that is in use causes an exception to be raised

  See https://docs.python.org/3/library/os.html#os.remove

Tree-SHA512: fbdabf3a9a838bb59ba207dd9e9fbdd87c702a99ad66bee0b2b1537f80f8630d22d9d5e9c4ded23a82a66bfc10989227fb024b27393425abe0e5a2ad4e4cbb82

@ken2812221 ken2812221 deleted the ken2812221:test-notification-fix branch Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.