Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] getblocktemplate: use SegWit in example #14472

Merged
merged 1 commit into from Oct 18, 2018

Conversation

@Sjors
Copy link
Member

@Sjors Sjors commented Oct 13, 2018

Make it less likely for new miners to accidentally mine non-SegWit blocks.

Suggest backport to 0.17 so the docs on bitcoincore.org get updated at the next minor release.

@fanquake fanquake added the Docs label Oct 13, 2018
@meshcollider
Copy link
Member

@meshcollider meshcollider commented Oct 14, 2018

Concept ACK

@fanquake
Copy link
Member

@fanquake fanquake commented Oct 14, 2018

Tagged for 0.17.1 & backport. There was a short related IRC discussion here.

@fanquake fanquake added this to the 0.17.1 milestone Oct 14, 2018
@laanwj
Copy link
Member

@laanwj laanwj commented Oct 18, 2018

utACK d562027

kallewoof pushed a commit to kallewoof/bitcoin that referenced this issue Oct 18, 2018
d562027 [doc] getblocktemplate: use SegWit in example (Sjors Provoost)

Pull request description:

  Make it less likely for new miners to accidentally mine non-SegWit blocks.

  Suggest backport to 0.17 so the docs on bitcoincore.org get updated at the next minor release.

Tree-SHA512: fc8c51690559d3e64d03c0eec433c75e5581d616d36b529e16f89ff2433457386feba7ef3b0d22f245d3f725183a2204fef7ee13e25cb92b945ab61f99068dee
@laanwj laanwj merged commit d562027 into bitcoin:master Oct 18, 2018
2 checks passed
@Sjors Sjors deleted the 2018/10/doc-getblocktemplate-segwit branch Oct 18, 2018
sipa added a commit that referenced this issue Oct 20, 2018
f7dbcaa [doc] getblocktemplate: use SegWit in example (Sjors Provoost)

Pull request description:

  Backport of #14472

Tree-SHA512: ac0863b5f04abe2cbdbb44f376094aa6c224aecd6d3a87689a2bb5a939cb18503eab6e33bfb9814dd2129ddf1dae0118054afc8eb4c438bd390c172defab343b
@fanquake
Copy link
Member

@fanquake fanquake commented Oct 20, 2018

Backported in #14509.

PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 27, 2021
d562027 [doc] getblocktemplate: use SegWit in example (Sjors Provoost)

Pull request description:

  Make it less likely for new miners to accidentally mine non-SegWit blocks.

  Suggest backport to 0.17 so the docs on bitcoincore.org get updated at the next minor release.

Tree-SHA512: fc8c51690559d3e64d03c0eec433c75e5581d616d36b529e16f89ff2433457386feba7ef3b0d22f245d3f725183a2204fef7ee13e25cb92b945ab61f99068dee
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 28, 2021
d562027 [doc] getblocktemplate: use SegWit in example (Sjors Provoost)

Pull request description:

  Make it less likely for new miners to accidentally mine non-SegWit blocks.

  Suggest backport to 0.17 so the docs on bitcoincore.org get updated at the next minor release.

Tree-SHA512: fc8c51690559d3e64d03c0eec433c75e5581d616d36b529e16f89ff2433457386feba7ef3b0d22f245d3f725183a2204fef7ee13e25cb92b945ab61f99068dee
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jun 29, 2021
d562027 [doc] getblocktemplate: use SegWit in example (Sjors Provoost)

Pull request description:

  Make it less likely for new miners to accidentally mine non-SegWit blocks.

  Suggest backport to 0.17 so the docs on bitcoincore.org get updated at the next minor release.

Tree-SHA512: fc8c51690559d3e64d03c0eec433c75e5581d616d36b529e16f89ff2433457386feba7ef3b0d22f245d3f725183a2204fef7ee13e25cb92b945ab61f99068dee
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants