Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Warn (don't fail!) on spelling errors #14495

Merged
merged 2 commits into from Oct 17, 2018

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Oct 16, 2018

Revert codespell policy change introduced in #14179.

Context: #13954 (comment)

@laanwj
Copy link
Member

@laanwj laanwj commented Oct 16, 2018

utACK
please let's not go back and forth with this or i'm going to add a linter that rejects linters/

@meshcollider
Copy link
Member

@meshcollider meshcollider commented Oct 16, 2018

utACK c32cf6a

Ping @MarcoFalke

@sipa
Copy link
Member

@sipa sipa commented Oct 17, 2018

utACK c32cf6a

@sipa sipa merged commit c32cf6a into bitcoin:master Oct 17, 2018
2 checks passed
sipa added a commit that referenced this issue Oct 17, 2018
c32cf6a Add ignored word: mut (practicalswift)
4ae50da Revert "qa: Fix codespell error and have lint-spelling error instead of warn" (practicalswift)

Pull request description:

  Revert `codespell` policy change introduced in #14179.

  Context: #13954 (comment)

Tree-SHA512: 4606b19bb32cdd661f90b3778759818d3493e5ed1a4a2f95982f07eeb6b9c889bc8d53cde31706e0a3b9524c3d3a7378f1b769a60baeb0d00da4c68fd3068114
@practicalswift practicalswift deleted the revert-codespell branch Apr 10, 2021
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 17, 2021
c32cf6a Add ignored word: mut (practicalswift)
4ae50da Revert "qa: Fix codespell error and have lint-spelling error instead of warn" (practicalswift)

Pull request description:

  Revert `codespell` policy change introduced in bitcoin#14179.

  Context: bitcoin#13954 (comment)

Tree-SHA512: 4606b19bb32cdd661f90b3778759818d3493e5ed1a4a2f95982f07eeb6b9c889bc8d53cde31706e0a3b9524c3d3a7378f1b769a60baeb0d00da4c68fd3068114
UdjinM6 added a commit to UdjinM6/dash that referenced this issue Jul 19, 2021
c32cf6a Add ignored word: mut (practicalswift)
4ae50da Revert "qa: Fix codespell error and have lint-spelling error instead of warn" (practicalswift)

Pull request description:

  Revert `codespell` policy change introduced in bitcoin#14179.

  Context: bitcoin#13954 (comment)

Tree-SHA512: 4606b19bb32cdd661f90b3778759818d3493e5ed1a4a2f95982f07eeb6b9c889bc8d53cde31706e0a3b9524c3d3a7378f1b769a60baeb0d00da4c68fd3068114
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 19, 2021
c32cf6a Add ignored word: mut (practicalswift)
4ae50da Revert "qa: Fix codespell error and have lint-spelling error instead of warn" (practicalswift)

Pull request description:

  Revert `codespell` policy change introduced in bitcoin#14179.

  Context: bitcoin#13954 (comment)

Tree-SHA512: 4606b19bb32cdd661f90b3778759818d3493e5ed1a4a2f95982f07eeb6b9c889bc8d53cde31706e0a3b9524c3d3a7378f1b769a60baeb0d00da4c68fd3068114
PastaPastaPasta added a commit to PastaPastaPasta/dash that referenced this issue Jul 19, 2021
c32cf6a Add ignored word: mut (practicalswift)
4ae50da Revert "qa: Fix codespell error and have lint-spelling error instead of warn" (practicalswift)

Pull request description:

  Revert `codespell` policy change introduced in bitcoin#14179.

  Context: bitcoin#13954 (comment)

Tree-SHA512: 4606b19bb32cdd661f90b3778759818d3493e5ed1a4a2f95982f07eeb6b9c889bc8d53cde31706e0a3b9524c3d3a7378f1b769a60baeb0d00da4c68fd3068114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants